Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-generate library using pubsub/synth.py #6223

Merged
merged 1 commit into from
Oct 17, 2018
Merged

Re-generate library using pubsub/synth.py #6223

merged 1 commit into from
Oct 17, 2018

Conversation

dpebot
Copy link
Contributor

@dpebot dpebot commented Oct 16, 2018

This PR was created by autosynth.

@dpebot dpebot requested a review from crwilcox as a code owner October 16, 2018 16:37
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 16, 2018
@tseaver tseaver added codegen api: pubsub Issues related to the Pub/Sub API. labels Oct 17, 2018
@tseaver
Copy link
Contributor

tseaver commented Oct 17, 2018

Pubsub tests did not actually run, due to #6231. Please hold off merging until that issue is fixed, and then force a rebuild for the Kokoro Pubsub job(how?)

@tseaver tseaver added do not merge Indicates a pull request not ready for merge, due to either quality or timing. status: blocked Resolving the issue is dependent on other work. labels Oct 17, 2018
@crwilcox crwilcox added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 17, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 17, 2018
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 17, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 17, 2018
@tseaver
Copy link
Contributor

tseaver commented Oct 17, 2018

Attempting to force Kokoro to run: I don't know if it runs against a trial merge of current master, or the PRs own branch, so fixes in #6242 and #6243 may not help.

@tseaver tseaver removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. status: blocked Resolving the issue is dependent on other work. labels Oct 17, 2018
@tseaver
Copy link
Contributor

tseaver commented Oct 17, 2018

Storage test failure (#62244) is unrelated.

@tseaver tseaver merged commit c8d4f5d into master Oct 17, 2018
@tseaver tseaver deleted the autosynth-pubsub branch October 17, 2018 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement. codegen
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dpebot @tseaver @crwilcox @googlebot @kokoro-team