Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kokoro skipping jobs inappropriately #6231

Closed
tseaver opened this issue Oct 17, 2018 · 3 comments
Closed

Kokoro skipping jobs inappropriately #6231

tseaver opened this issue Oct 17, 2018 · 3 comments
Assignees
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. testing type: process A process-related concern. May include testing, release, or the like.

Comments

@tseaver
Copy link
Contributor

tseaver commented Oct 17, 2018

E.g., for PR #6202, which scribbles all over bigquery/, the Kokoro - BigQuery job logs (line 95)

bigquery was not modified, returning.

And returns successfully without running any tests.

@tseaver tseaver added testing priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: process A process-related concern. May include testing, release, or the like. labels Oct 17, 2018
@theacodes
Copy link
Contributor

Looks like the PR commit Sha and diffbas were the same for some reason. Will investigate tomorrow.

@tseaver
Copy link
Contributor Author

tseaver commented Oct 17, 2018

Hmm, looks like kokoro may have gone from skipping everything to running everything: two failures on PR #6202, which is pure BigQuery:

@theacodes
Copy link
Contributor

theacodes commented Oct 17, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. testing type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Development

No branches or pull requests

3 participants