Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the ASP.NET Core on GCE warning message. #1066

Merged
merged 2 commits into from
Oct 12, 2018
Merged

Update the ASP.NET Core on GCE warning message. #1066

merged 2 commits into from
Oct 12, 2018

Conversation

ILMTitan
Copy link

@ILMTitan ILMTitan commented Oct 11, 2018 •
edited
Loading

image

@ILMTitan ILMTitan added this to the 2.0.0 milestone Oct 11, 2018
@ILMTitan ILMTitan self-assigned this Oct 11, 2018
@codecov
Copy link

codecov bot commented Oct 11, 2018 •
edited
Loading

Codecov Report

Merging #1066 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1066      +/-   ##
==========================================
+ Coverage   49.75%   49.76%   +0.01%     
==========================================
  Files         479      479              
  Lines       11724    11727       +3     
==========================================
+ Hits         5833     5836       +3     
  Misses       5891     5891
Impacted Files Coverage Δ
...teps/CoreGceWarning/CoreGceWarningStepViewModel.cs 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e21761c...33e53c5. Read the comment docs.

iantalarico
iantalarico reviewed Oct 12, 2018
View reviewed changes
Copy link
Contributor

@iantalarico iantalarico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a little context to the PR description and maybe a quick screenshot?

Will another change make the default not to show this message again?

...nsion/GoogleCloudExtension/PublishDialog/Steps/CoreGceWarning/CoreGceWarningStepContent.xaml Outdated
</Hyperlink>

<Run Text="{x:Static ext:Resources.PublishGceWarningStepLine2AfterLink}"/>
</wpf:WhitespaceDiscardingSpan>

<LineBreak />
<LineBreak/>
Copy link
Contributor

@iantalarico iantalarico Oct 12, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super nit: <LineBreak />

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@ILMTitan
Copy link
Author

PTAL.
Updated with a screenshot of the new warning message.
After consideration, I decided auto-selecting "Don't show this warning again" was not a great idea. If someone quickly clicks through the warning, they would have no way to get back to it, and would be left wondering what it was.

iantalarico
iantalarico approved these changes Oct 12, 2018
View reviewed changes
Copy link
Contributor

@iantalarico iantalarico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call on the checkbox, you're right if they don't want to see the message they can check the box.

@ILMTitan ILMTitan merged commit 86bfaec into GoogleCloudPlatform:master Oct 12, 2018
@ILMTitan ILMTitan deleted the update-core-warning branch October 12, 2018 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iantalarico iantalarico iantalarico approved these changes

@quoctruong quoctruong quoctruong approved these changes

@simonz130 simonz130 Awaiting requested review from simonz130

Assignees

@ILMTitan ILMTitan

Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ILMTitan @quoctruong @iantalarico