Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Pub/Sub from the Cloud Explorer. #971

Merged
merged 4 commits into from
May 25, 2018

Conversation

ILMTitan
Copy link

@ILMTitan ILMTitan commented May 24, 2018

Fixes #945

@ILMTitan ILMTitan self-assigned this May 24, 2018
@ILMTitan ILMTitan requested review from iantalarico and redborian May 24, 2018 20:57
Copy link
Contributor

@redborian redborian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented May 25, 2018

Codecov Report

Merging #971 into master will decrease coverage by 2.14%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #971      +/-   ##
==========================================
- Coverage   37.71%   35.57%   -2.15%     
==========================================
  Files         487      458      -29     
  Lines       11839    11248     -591     
==========================================
- Hits         4465     4001     -464     
+ Misses       7374     7247     -127
Impacted Files Coverage Δ
...oogleCloudExtension/GoogleCloudExtensionPackage.cs 62.65% <ø> (ø) ⬆️
...dExtension/CloudExplorer/CloudExplorerViewModel.cs 75% <ø> (-0.52%) ⬇️
...oogleCloudExtension/Utils/ProtectedAsyncCommand.cs 100% <100%> (ø) ⬆️
...ogleCloudExtension/Utils/PropertyWindowItemBase.cs 0% <0%> (-41.18%) ⬇️
...sion/CloudExplorer/CloudExplorerSourceException.cs 25% <0%> (-25%) ⬇️
...sion/GoogleCloudExtension/Utils/UserPromptUtils.cs 54.71% <0%> (-22.65%) ⬇️
...oogleCloudExtension/UserPrompt/UserPromptWindow.cs 40% <0%> (-6.67%) ⬇️
...GoogleCloudExtension.DataSources/DataSourceBase.cs 96.66% <0%> (-3.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc74085...8ffad68. Read the comment docs.

@ILMTitan ILMTitan merged commit 2057b15 into GoogleCloudPlatform:master May 25, 2018
@ILMTitan ILMTitan deleted the issue-945 branch May 25, 2018 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants