Network manager netplan implementation #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dorileo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
dorileo
force-pushed
the
network-manager-netplan-implementation
branch
2 times, most recently
from
1399215 to
208b30b
Compare
dorileo
requested review from
ChaitanyaKulkarni28 and
drewhli
and removed request for
drewhli
dorileo
force-pushed
the
network-manager-netplan-implementation
branch
from
208b30b to
2555302
Compare
|
/hold |
dorileo
force-pushed
the
network-manager-netplan-implementation
branch
from
2555302 to
54358e4
Compare
|
/retest |
dorileo
force-pushed
the
network-manager-netplan-implementation
branch
3 times, most recently
from
9201903 to
a6f15b7
Compare
|
/retest |
dorileo
force-pushed
the
network-manager-netplan-implementation
branch
from
a6f15b7 to
654f02c
Compare
We have a use case of systemd-networkd + netplan managed configuration. This change allows us to chain more than one network manager when required. The rollback strategy has changed as well to apply the following semantics: select all managers that apply to the running system and rollback all the others that don't apply. The rollback procedures were adjusted to avoid failing whenever a configuration is not present.
Considering now that the logic of Rollback() calls has changed to be called to all the non active network managers the interface implementation is changing to not report error if the configuration is not found - or the pre condition is not met.
For systems running systemd-networkd alongside with netplan will have their configuration managed by netplan instead, we keep installing the .network and .netdev files as netplan can be removed.
Since we've had already released a version with the old section definition we should keep honoring it.
dorileo
force-pushed
the
network-manager-netplan-implementation
branch
from
654f02c to
9bc78df
Compare
|
/unhold |
|
/lgtm |
google-oss-prow
bot
merged commit a633f94
into
GoogleCloudPlatform:main
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.