Skip to content

Commit

Permalink
samples: fix dependencies and region tags for tests (#178)
Browse files Browse the repository at this point in the history
* samples: fix dependencies and region tags for tests

* samples: snapshot sample test should use snapshot

* fix END_EXCLUDE tag
  • Loading branch information
chingor13 authored Jun 18, 2020
1 parent de4b476 commit d4ae626
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 5 deletions.
5 changes: 5 additions & 0 deletions errorreporting/install-without-bom/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,11 @@
</dependency>
<!-- [END clouderrorreporting_install_without_bom] -->

<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-core</artifactId>
<version>1.93.6</version>
</dependency>
<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
Expand Down
11 changes: 8 additions & 3 deletions errorreporting/snapshot/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,20 @@
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
</properties>

<!-- {x-version-update-start::current} -->
<dependencies>
<!-- {x-version-update-start:google-cloud-errorreporting:current} -->
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-errorreporting</artifactId>
<version>0.119.2-beta</version>
<version>0.119.3-beta-SNAPSHOT</version>
</dependency>
<!-- {x-version-update-end} -->

<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-core</artifactId>
<version>1.93.6</version>
</dependency>
<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
Expand All @@ -44,7 +50,6 @@
<scope>test</scope>
</dependency>
</dependencies>
<!-- {x-version-update-end} -->

<!-- compile and run all snippet tests -->
<build>
Expand Down
9 changes: 7 additions & 2 deletions errorreporting/snippets/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,11 @@
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-errorreporting</artifactId>
</dependency>
<!-- [END clouderrorreporting_install_with_bom] -->

<!-- BEGIN_EXCLUDE -->
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-core</artifactId>
</dependency>
<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
Expand All @@ -56,5 +59,7 @@
<version>1.0.1</version>
<scope>test</scope>
</dependency>
<!-- END_EXCLUDE -->
</dependencies>
<!-- [END clouderrorreporting_install_with_bom] -->
</project>

0 comments on commit d4ae626

Please sign in to comment.