Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkstyle fixes in Cloud Storage JSON API tests. #109

Merged
merged 1 commit into from
Mar 15, 2016
Merged

Checkstyle fixes in Cloud Storage JSON API tests. #109

merged 1 commit into from
Mar 15, 2016

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Mar 15, 2016

Getting ready to use shared java-repo-tools configuration.

I also convert the assertions to use truth.

Since I find it more readable to get a list of object names first
instead of manually looping through, I also update the sample to use
Java 8 lambdas to extract these object names. The sample is used here:
https://cloud.google.com/storage/docs/json_api/v1/json-api-java-samples
which does not indicate the required Java version.

Depends on #107

<artifactId>maven-compiler-plugin</artifactId>
<version>2.5.1</version>
<configuration>
<source>1.8</source>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can specify this w/ the shortcut maven.compiler.source & maven.compiler.target -- it's one less thing we need to track.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in latest commit push. Thanks for the suggestion.

@lesv
Copy link
Contributor

lesv commented Mar 15, 2016

Just use <properties> and set maven.compiler.source & maven.compiler.target

Getting ready to use shared java-repo-tools configuration.

I also convert the assertions to use
[truth](http://google.github.io/truth/).

Since I find it more readable to get a list of object names first
instead of manually looping through, I also update the sample to use
Java 8 lambdas to extract these object names. The sample is used here:
https://cloud.google.com/storage/docs/json_api/v1/json-api-java-samples
which does not indicate the required Java version.
@tswast tswast changed the title Checkstyle fixes in Cloud Storage JSON API tests [wait for #107 to merge first]. Checkstyle fixes in Cloud Storage JSON API tests. Mar 15, 2016
@lesv
Copy link
Contributor

lesv commented Mar 15, 2016

LGTM

lesv added a commit that referenced this pull request Mar 15, 2016
Checkstyle fixes in Cloud Storage JSON API tests.
@lesv lesv merged commit 14e393a into master Mar 15, 2016
@tswast tswast deleted the csstorage branch March 17, 2016 17:16
averikitsch pushed a commit that referenced this pull request Oct 27, 2022
…uration to v1.0.15 (#109)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [com.google.cloud.samples:shared-configuration](https://togithub.com/GoogleCloudPlatform/java-repo-tools) | patch | `1.0.14` -> `1.0.15` |

---

### Release Notes

<details>
<summary>GoogleCloudPlatform/java-repo-tools</summary>

### [`v1.0.15`](https://togithub.com/GoogleCloudPlatform/java-repo-tools/releases/v1.0.15)

[Compare Source](https://togithub.com/GoogleCloudPlatform/java-repo-tools/compare/v1.0.14...v1.0.15)

-   Move some stuff around (in prep for a change to release process) pom.xml's
-   Add an exclude filter for SpotBugs. (disable the Java 11 surprise)
-   Don't fail on SpotBugs issues for now
-   add PMD reporting
-   Don't fail on PMD issues for now.

</details>

---

### Renovate configuration

:date: **Schedule**: At any time (no schedule defined).

:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

:recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/java-tasks).
averikitsch pushed a commit that referenced this pull request Nov 1, 2022
…uration to v1.0.15 (#109)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [com.google.cloud.samples:shared-configuration](https://togithub.com/GoogleCloudPlatform/java-repo-tools) | patch | `1.0.14` -> `1.0.15` |

---

### Release Notes

<details>
<summary>GoogleCloudPlatform/java-repo-tools</summary>

### [`v1.0.15`](https://togithub.com/GoogleCloudPlatform/java-repo-tools/releases/v1.0.15)

[Compare Source](https://togithub.com/GoogleCloudPlatform/java-repo-tools/compare/v1.0.14...v1.0.15)

-   Move some stuff around (in prep for a change to release process) pom.xml's
-   Add an exclude filter for SpotBugs. (disable the Java 11 surprise)
-   Don't fail on SpotBugs issues for now
-   add PMD reporting
-   Don't fail on PMD issues for now.

</details>

---

### Renovate configuration

:date: **Schedule**: At any time (no schedule defined).

:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

:recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/java-tasks).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants