Skip to content

Session Handling with Firestore tutorial. #1746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 16, 2019
Merged

Session Handling with Firestore tutorial. #1746

merged 3 commits into from
Dec 16, 2019

Conversation

@dzlier-gcp
Copy link
Member

@dzlier-gcp dzlier-gcp commented Nov 18, 2019

No description provided.

@dzlier-gcp dzlier-gcp requested a review from a team November 18, 2019 21:34
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 18, 2019
@dzlier-gcp dzlier-gcp added the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 18, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 18, 2019
kurtisvg
kurtisvg suggested changes Nov 19, 2019
View reviewed changes
@dzlier-gcp dzlier-gcp force-pushed the master branch 2 times, most recently from 29cdc06 to d41b4de Compare November 19, 2019 18:45
@dzlier-gcp
Copy link
Member Author

dzlier-gcp commented Nov 19, 2019

feedback done

@dzlier-gcp dzlier-gcp force-pushed the master branch 2 times, most recently from a73f999 to d41b4de Compare November 25, 2019 18:59
@dzlier-gcp
Copy link
Member Author

dzlier-gcp commented Nov 25, 2019

Ping

kurtisvg
kurtisvg suggested changes Nov 26, 2019
View reviewed changes
Copy link
Contributor

@kurtisvg kurtisvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of remaining issues with error handling.

run/session-handling/src/main/java/com/example/gettingstarted/actions/HelloWorldServlet.java Outdated
}
String greeting = greetingValue.toString();

System.out.println("Writing response " + req.toString());
Copy link
Contributor

@kurtisvg kurtisvg Nov 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still printing to stdout

@dzlier-gcp dzlier-gcp force-pushed the master branch 2 times, most recently from 9e08472 to 71423fb Compare December 2, 2019 21:28
@dzlier-gcp
Copy link
Member Author

dzlier-gcp commented Dec 2, 2019

Other feedback changes done.

dzlier-gcp
dzlier-gcp commented Dec 5, 2019
View reviewed changes
Copy link
Member Author

@dzlier-gcp dzlier-gcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feedback fixed

@dzlier-gcp
Copy link
Member Author

dzlier-gcp commented Dec 11, 2019

Ping

@dzlier-gcp
Copy link
Member Author

dzlier-gcp commented Dec 16, 2019

I think the other Run tutorials are written differently for testing purposes, as they have their own special test run script in Kokoro that doesn't seem to work with this one. I'm moving the sample to the base directory.

@dzlier-gcp dzlier-gcp merged commit 1a310e4 into GoogleCloudPlatform:master Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kurtisvg kurtisvg kurtisvg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kurtisvg kurtisvg

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dzlier-gcp @kurtisvg @googlebot @kokoro-team @lesv