Demosite app recaptcha changes #7706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
faube
commented
Feb 22, 2023
faube
commented
- Specify a container_name to simplify docker operations
- Remove unhelpful invalidReason from the response. null is not a valid value.
product-auto-label
bot
added
samples
Sita04
approved these changes
Feb 22, 2023
Sita04
pushed a commit
that referenced
this pull request
Mar 3, 2023
* Specify a container_name to simplify docker operations. * Remove unhelpful from the response.
Sita04
added a commit
that referenced
this pull request
Mar 15, 2023
* docs(recaptcha-app): init add webapp * mapping exposed Docker port to app * update port * Change default port from 8000 to 8080. (#7633) * refactor: Demosite alignment with new UI * add UI files * updated static file references * refactoring * updated dockerfiles to exclude checkbox key * fixed templating issue * refactor to demo site_key best practice * lint fix * remove unrelated file * skip checkstyle plugin * fix typo * updated acc to review comments * Add an optional DOCKER_COMPOSE_USER environment variable. This can be helpful such that files get created by the same user that is running docker * updated assessment verdict, added README and comment in dockerfiles * add test file * Demosite app recaptcha changes (#7706) * Specify a container_name to simplify docker operations. * Remove unhelpful from the response. * refactor test file * fix xpath for testcases * fix year in header * updated acc to review comments * docs(recaptcha-app): init add webapp * update port * Change default port from 8000 to 8080. (#7633) * refactor: Demosite alignment with new UI * add UI files * refactoring * refactor to demo site_key best practice * remove unrelated file * moving pom back as this change is unrelated to demosite * readme typo fix * updated acc to review comments * remove local css, update json parsing, errors * modify response entity to be idiomatic * update getElement to use shadowRoot * update browser test selectors * lint * add libnss3 * test * test: adding libnss to verify if the chrome driver starts * update libnss install command * fix dependencies * Update run_tests.sh * Update run_tests.sh * setup driver in docker * remove drivermanager and set driver path * update driver path * set driver path with chromeoptions * debug installation * temporarily ignore tests --------- Co-authored-by: Cory Kramer <coryakramer@gmail.com> Co-authored-by: François Aubé <faube@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.