-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue#8261 : Added test cases for InfiniteStreamRecognize class #9498
base: main
Are you sure you want to change the base?
Issue#8261 : Added test cases for InfiniteStreamRecognize class #9498
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is an expected running time for this test?
based on lack of test input it looks like the code sample will wait for input and get terminated after 5 minutes.
System.setErr(new PrintStream(stderr)); | ||
} | ||
|
||
@After | ||
public void tearDown() { | ||
System.setOut(originalStdout); | ||
System.setErr(originalStderr); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: what is a reason to intercept Stderr if the test validates only Stdout?
I converted PR to draft because it does not pass automatic testing. Please, ensure that all tests pass before submitting it to the review. |
Description
Fixes #8261
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
pom.xml
parent set to latestshared-configuration
mvn clean verify
requiredmvn -P lint checkstyle:check
requiredmvn -P lint clean compile pmd:cpd-check spotbugs:check
advisory only