feat(security-center): Add Resource v2 API Assets Security Marks Samples #9680
Conversation
|
Here is the summary of changes. You are about to add 3 region tags.
This comment is generated by snippet-bot.
|
product-auto-label
bot
added
api: securitycenter
vijaykanthm
added
kokoro:run
kokoro-team
removed
the
kokoro:force-run
owenhuyn
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
vijaykanthm
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
| import com.google.protobuf.FieldMask; | ||
| import java.io.IOException; | ||
|
|
||
| //[START securitycenter_add_delete_security_marks_assets_v2] |
There was a problem hiding this comment.
place region tags to enclose necessary imports and the code sample method. no need to leave space lines between the region tags and the code
| public class AddDeleteSecurityMarks { | ||
| public static void main(String[] args) throws IOException { | ||
| // organizationId: Google Cloud Organization id. | ||
| String organizationId = "{google-cloud-organization-id}"; |
There was a problem hiding this comment.
please align the style of the ID with other code samples. No need for curly brackets. Most of code samples use capitalized expression like PROJECT_ID or ORGANIZATION_ID
| String organizationId = "{google-cloud-organization-id}"; | ||
|
|
||
| // Specify the finding-id. | ||
| String assetId = "{asset-id}"; |
There was a problem hiding this comment.
same here. note that "finding-id" is not used anywhere. consider to refactor the comment
| // Specify the location. | ||
| String location = "global"; |
There was a problem hiding this comment.
does your code sample support other locations? if not, please use this literal inside the code sample method instead of using it as parameter. if a user can use different locations, provide a link to documentation that enumerates these locations in the comment for this argument.
| // Demonstrates adding/updating at the same time as deleting security | ||
| // marks from an asset. | ||
| // To add or change security marks, you must have an IAM role that includes permission: |
There was a problem hiding this comment.
no need for comments here.
| final PrintStream out = System.out; | ||
| stdOut = new ByteArrayOutputStream(); | ||
| System.setOut(new PrintStream(stdOut)); |
There was a problem hiding this comment.
please use return values instead of capturing and parsing stdout.
| stdOut = new ByteArrayOutputStream(); | ||
| System.setOut(new PrintStream(stdOut)); | ||
|
|
||
| requireEnvVar("GOOGLE_APPLICATION_CREDENTIALS"); |
There was a problem hiding this comment.
nit: you can skip this check
| // Fetch a valid asset ID dynamically | ||
| try (SecurityCenterClient client = SecurityCenterClient.create()) { | ||
| OrganizationName orgName = OrganizationName.of(ORGANIZATION_ID); | ||
| ListAssetsRequest request = | ||
| ListAssetsRequest.newBuilder().setParent(orgName.toString()).setPageSize(1).build(); | ||
|
|
||
| Asset asset = client.listAssets(request).iterateAll().iterator().next().getAsset(); | ||
| assetName = asset.getName(); // Get the full resource name for the asset | ||
| assetId = extractAssetId(assetName); | ||
| } catch (InvalidArgumentException e) { | ||
| System.err.println("Error retrieving asset ID: " + e.getMessage()); | ||
| throw e; | ||
| } |
There was a problem hiding this comment.
setup method is used to create resources. you cannot assume that a resource exists before the tests are executed. in rare occasions when tests use pre-provisioned resources (e.g. because provisioning a resource takes too long), all required attributes of the resource are hardcoded and expressed via environment variables in the testing environment.
|
|
||
| stdOut = null; | ||
| System.setOut(out); | ||
| TimeUnit.MINUTES.sleep(1); |
| stdOut = new ByteArrayOutputStream(); | ||
| System.setOut(new PrintStream(stdOut)); |
There was a problem hiding this comment.
do not capture stdout stream
Description
This PR adds v2 API Assets Security Marks Java client samples to Add Security Marks, Delete Security Marks, Add Delete Security Marks.
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
pom.xmlparent set to latestshared-configurationmvn clean verifyrequiredmvn -P lint checkstyle:checkrequiredmvn -P lint clean compile pmd:cpd-check spotbugs:checkadvisory only