Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore updates to MySQL connector. Don't ignore -beta. #51

Merged
merged 1 commit into from
Dec 19, 2016

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Dec 19, 2016

@lesv PTAL

@tswast tswast requested a review from jerjou December 19, 2016 21:53
@tswast
Copy link
Contributor Author

tswast commented Dec 19, 2016

In response to GoogleCloudPlatform/java-docs-samples#456 (comment) (for MySQL filter) and GoogleCloudPlatform/java-docs-samples#458 (for allowing -beta versions)

@tswast tswast merged commit 867ae2d into master Dec 19, 2016
@tswast tswast deleted the versionsignore branch December 19, 2016 21:55
@@ -32,6 +31,14 @@ limitations under the License.
<ignoreVersion type="regex">.*</ignoreVersion>
</ignoreVersions>
</rule>
<!-- MySQL connector should not be manually updated.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you mean "automatically updated"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants