Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quickstart support? #12

Closed
gregw opened this issue Sep 8, 2016 · 8 comments
Closed

quickstart support? #12

gregw opened this issue Sep 8, 2016 · 8 comments

Comments

@gregw
Copy link
Contributor

gregw commented Sep 8, 2016

Should quickstart be supported by default, or documented as a desirable feature.
Testing done in #8 using quickstart and/or annotations

@meltsufin
Copy link
Member

What would implementing quickstart support entail? Is it just turning on the quickstart module? Does the app have to be built a different way to work with quickstart?

@gregw
Copy link
Contributor Author

gregw commented Sep 8, 2016

It is a module that needs to be turned on, plus the webapp needs to be built with a quickstart-war file.

So if there is going to be SDK support to deploy webapps to this image, it is a good option to have to save CPUs. If there is no SDK support, then it is something the users can turn on themselves and we should just prepare an example project and documentation.

@janbartel
Copy link
Contributor

See issue #25 also.

@ludoch
Copy link
Contributor

ludoch commented Sep 15, 2016

pure jetty-runtime does not have prebaked SDK support.
The user could modify her pom.xml to enable quickstart?

On Thu, Sep 15, 2016 at 4:06 PM, Jan Bartel notifications@github.com
wrote:

See issue #25
#25 also.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#12 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAE4zUGSz3JFqBBvkIvsx_IULfNGvnaVks5qqc-DgaJpZM4J3hvw
.

@gregw
Copy link
Contributor Author

gregw commented Sep 16, 2016

To use quickstart a user would need to:

  • add a quickstart-web.xml to WEB-INF
  • enable the quickstart module on the jetty base.

Both are simple to do, so I think this is more a documentation/example issue rather than a coded feature.

@meltsufin
Copy link
Member

Would they need to build a custom runtime to enable the quickstart module?

@gregw
Copy link
Contributor Author

gregw commented Sep 20, 2016

@meltsufin, yes they would need to provide their own Dockerfile that enables the quickstart module.

@joakime
Copy link
Contributor

joakime commented Sep 21, 2016

the regression testing could handle that in /jetty-runtime/ easily enough.

Each /tests/webapp/test-war-*/ has its own docker.

To do:

  • Add new test project
  • Dockerfile updated to add the quickstart module to the jetty.base
  • test-war-quickstart has maven plugin that builds out the quickstart-web.xml
  • deploy and integration testing as usual

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants