Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf app tuning #136

Open
ludoch opened this issue Mar 2, 2017 · 3 comments
Open

perf app tuning #136

ludoch opened this issue Mar 2, 2017 · 3 comments
Assignees
@olamy

Comments

@ludoch
Copy link
Contributor

ludoch commented Mar 2, 2017

Looking at the perf branch

1/ not sure you need appengine-web.xml since you have app.yaml
https://github.com/GoogleCloudPlatform/jetty-runtime/blob/feature/perf/perf/perf-server/src/main/webapp/WEB-INF/appengine-web.xml

2/ the app.yaml should use env:flex instead of vm:true which is deprecated (and possibly a slower request path)
olamy added a commit to olamy/jetty-runtime that referenced this issue Mar 2, 2017
@olamy
move to env: flex, no need of appengine-web.xml see GoogleCloudPlatfo…
468590d 
…rm#136

Signed-off-by: olivier lamy <olamy@apache.org>
olamy added a commit that referenced this issue Mar 2, 2017
@olamy
move to env: flex, no need of appengine-web.xml see #136
03bb343 
Signed-off-by: olivier lamy <olamy@apache.org>
@olamy olamy self-assigned this Mar 2, 2017
@olamy
Copy link

olamy commented Mar 2, 2017 •
edited
Loading

Thanks for reviewing.
I changed that
It looks with this change we cannot see anymore the number of instance in console.cloud.google.com ? Compute Engine / VM Instances.

@ludoch
Copy link
Contributor Author

ludoch commented Mar 2, 2017

Thanks!

That would be a regression in the console for Flex? Mike: ideas?

@meltsufin
Copy link
Member

You should be able to see Flex instances under App Engine / Versions or App Engine / Instances.

olamy added a commit that referenced this issue May 24, 2017
@olamy
move to env: flex, no need of appengine-web.xml see #136
a468682 
Signed-off-by: olivier lamy <olamy@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olamy olamy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@olamy @ludoch @meltsufin