Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade KCC operator to version 1.113.0 #1143

Conversation

justinsb
Copy link
Collaborator

Generated using make upgrade-kcc

Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

fieldRef:
fieldPath: metadata.namespace
image: gke.gcr.io/prometheus-to-sd:v0.11.12-gke.0
name: prom-to-sd
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is removing "prom-to-sd" intentional?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch - and @gemmahou caught this also! We think it was caused by a newer version of kustomize; we should make sure that make upgrade-kcc (and everything) runs with a known version of kustomize

Copy link
Collaborator

@acpana acpana Jan 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

( automated PR also staging removal: ref )

Generated using `make upgrade-kcc`
@justinsb justinsb force-pushed the update_operator_for_1_113_0 branch from 786a701 to 79b24e1 Compare January 23, 2024 23:01
@justinsb
Copy link
Collaborator Author

We hit the issue that should be fixed by #1114 "timeout waiting for process kube-apiserver to stop" ; re-running tests

@justinsb
Copy link
Collaborator Author

Fixed up the problem with the kustomize version, removed the "WIP" designation. Should be ready for review now!

Copy link
Collaborator

@jingyih jingyih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jan 24, 2024
@google-oss-prow google-oss-prow bot merged commit 864da87 into GoogleCloudPlatform:master Jan 24, 2024
6 checks passed
@jingyih
Copy link
Collaborator

jingyih commented Jan 24, 2024

Fixed up the problem with the kustomize version, removed the "WIP" designation. Should be ready for review now!

For my education, could you elaborate a bit more on the fix?

Oh never mind, I just saw the issue opened by you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants