-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade KCC operator to version 1.113.0 #1143
Upgrade KCC operator to version 1.113.0 #1143
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fieldRef: | ||
fieldPath: metadata.namespace | ||
image: gke.gcr.io/prometheus-to-sd:v0.11.12-gke.0 | ||
name: prom-to-sd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is removing "prom-to-sd" intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch - and @gemmahou caught this also! We think it was caused by a newer version of kustomize; we should make sure that make upgrade-kcc
(and everything) runs with a known version of kustomize
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
( automated PR also staging removal: ref )
Generated using `make upgrade-kcc`
786a701
to
79b24e1
Compare
We hit the issue that should be fixed by #1114 "timeout waiting for process kube-apiserver to stop" ; re-running tests |
Fixed up the problem with the kustomize version, removed the "WIP" designation. Should be ready for review now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
864da87
into
GoogleCloudPlatform:master
Oh never mind, I just saw the issue opened by you. |
Generated using
make upgrade-kcc