Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated checksums #8

Closed
wants to merge 5 commits into from
Closed

Updated checksums #8

wants to merge 5 commits into from

Conversation

ovk6
Copy link
Contributor

@ovk6 ovk6 commented Jun 26, 2019

Updated versions.yaml because checksums for source tarballs downloaded from github.com/.../.../archive can change over time.

@ovk6 ovk6 requested a review from wgrzelak June 26, 2019 13:22
@wgrzelak
Copy link
Collaborator

@jprzychodzen do you have more context on this, right?

@jprzychodzen
Copy link

@wgrzelak No I do not. There was an issue with changing checksum, but it was an empty file.

@ovk6 What is the reason for this checksum to change? Changing checksum means that file has changed.

@ovk6
Copy link
Contributor Author

ovk6 commented Jul 1, 2019 •
edited
Loading

@jprzychodzen
Nope, it was not about empty files. What you showed me locally had nothing to do with tests run for container and didn't occur during tests.

Anyway it looks like we have issue similar to easybuilders/easybuild-easyconfigs#5151 or spack/spack#5411, that also hit several other projects.
Shortly we cannot rely on checksums for files downloaded from github.com/.../.../archive, because they are generated dynamically and can change over time.

wgrzelak
wgrzelak requested changes Jul 1, 2019
View reviewed changes
Copy link
Collaborator

@wgrzelak wgrzelak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed to be clarify.

@ovk6 ovk6 requested a review from khajduczenia July 1, 2019 12:54
@ovk6
Copy link
Contributor Author

ovk6 commented Jul 3, 2019

Outdated

@ovk6 ovk6 closed this Jul 3, 2019
@ovk6 ovk6 deleted the updated_versions branch October 24, 2019 15:15
@ovk6 ovk6 mentioned this pull request Oct 24, 2019
Merged
@armandomiani armandomiani restored the updated_versions branch June 7, 2023 09:16
@armandomiani armandomiani reopened this Jun 7, 2023
@armandomiani armandomiani requested a review from a team as a code owner June 7, 2023 09:16
@armandomiani armandomiani deleted the updated_versions branch June 7, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wgrzelak wgrzelak wgrzelak requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ovk6 @wgrzelak @jprzychodzen @armandomiani