JAX Hello World Multi-Node GKE H100 with GPUDirectTCPx tutorial #1236 #1237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parambole
requested review from
rbarberop,
alizaidis,
yoshi-approver and
a team
as code owners
bourgeoisor
reviewed
Jun 12, 2024
There was a problem hiding this comment.
Adding a few minor comments. Feel free to ping me when the PR is stable and ready for review, @parambole !
| @@ -0,0 +1,53 @@ | |||
| # JAX Mult-Node 'Hello World' on GKE + H100-80GB with GPUDirectTCPx | |||
There was a problem hiding this comment.
Typically we'll have instructions be the Google Cloud docs tutorial, and point to that from here. This reduces duplication and makes it so we only have to modify the instructions in one source of truth (the tutorial)
| @@ -0,0 +1,14 @@ | |||
| FROM python:3.10-slim | |||
There was a problem hiding this comment.
Could you make a workflow that does at minimum docker build as a dry-run that it does build? You can find some examples in the .github/workflows directory
|
@parambole hi! Friendly ping for these samples |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds JAX Hello World Multi-Node GKE H100 with GPUDirectTCPx tutorial
Tasks