-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding trillium support for maxdiffusion tutorial #1469
Conversation
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I trust that you've done the appropriate testing.
Approving. Tag me if you'd like me to merge this.
jax==0.4.31 | ||
jaxlib==0.4.31 | ||
#jax==0.4.31 # installed in Dockerfile | ||
#jaxlib==0.4.31 # installed in Dockerfile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: Is there a reason we now install these via the Dockerfile?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NimJay no, I've moved it into the requirements file with latest commit and can confirm the deployment and inference working.
The latest jax nightly comes with the required libtpu for Trillium, so have removed jaxlib as well.
As this is is a maxdiffusion with TPU tutorial, I've also changed to use jax[tpu] as the GPU binaries arent needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That awesome. Thanks for doing that.
Let me know (tag me) when you'd like me to merge this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NimJay please merge with main. Thank you
This is to add trillium support for the Serve Stable Diffusion XL (SDXL) using TPUs on GKE with MaxDiffusion by adding latest JAX + libtpu install binaries, and kubernetes deployment example to launch a trillium serving pod