Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add test image for maven vulnerability scanning #749

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

thompsonmax
Copy link
Contributor

Image will be used in a upcoming new tutorial that is WIP.

  • Add sample app and Dockerfile for image with maven vulns
  • Add sample deployment of the image
  • Update CODEOWNERS for the new image
  • Add cloudbuild for the new image
  • Update terraform build triggers to include the new image

@thompsonmax thompsonmax requested review from a team and yoshi-approver as code owners July 25, 2023 23:34
@bourgeoisor
Copy link
Member

Hi @thompsonmax thanks for your PR! Is this an upcoming tutorial that will be published on c.g.c for GKE?

@bourgeoisor bourgeoisor self-assigned this Jul 26, 2023
@thompsonmax
Copy link
Contributor Author

Hi @bourgeoisor, yes this is for an upcoming tutorial that will be published on c.g.c. for GKE, which is being written by @shannonxtreme. The tutorial is not published yet so I did not include a README with a link to it per the contributing instructions.

Image will be used in a upcoming new tutorial that is WIP.

* Add sample app and Dockerfile for image with maven vulns
* Add sample deployment of the image
* Update CODEOWNERS for the new image
* Add cloudbuild for the new image
* Update terraform build triggers to include the new image
Copy link
Contributor

@minherz minherz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@minherz minherz merged commit 57a34a1 into GoogleCloudPlatform:main Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants