Migrate google_compute_firewall_policy_rule resource from DCL to MMv1 #11360

Samir-Cit · 2024-08-05T20:15:03Z

Hello folks.
This PR is to move the Firewall Policy Rule (google_compute_firewall_policy_rule) resource from DCL to MMv1. And this PR includes:

Creation of the resource on MMv1.
Creation of the examples and tests.
Remove references to DCL resource.

Note: This PR doesn't include the deletion of the DCL resource. This change will be done on the Delarative Resource Client Library repository.

Release Note Template for Downstream PRs (will be copied)

compute: `google_compute_firewall_policy_rule` now uses MMv1 engine instead of DCL.

github-actions · 2024-08-09T22:19:23Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2024-08-09T23:28:07Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1110 insertions(+), 594 deletions(-))
google-beta provider: Diff ( 5 files changed, 1110 insertions(+), 594 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 428 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

Field kind within resource google_compute_firewall_policy_rule was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_firewall_policy_rule (10 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_firewall_policy_rule" "primary" {
  match {
    src_secure_tags {
      name = # value needed
    }
  }
  rule_name = # value needed
  target_secure_tags {
    name = # value needed
  }
  tls_inspect = # value needed
}

Errors

google provider:

The diff processor failed to build. This is usually due to the downstream provider failing to compile.

modular-magician · 2024-08-09T23:44:01Z

Tests analytics

Total tests: 979
Passed tests: 903
Skipped tests: 72
Affected tests: 4

Click here to see the affected service packages

compute

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeFirewallPolicyRule_firewallPolicyRuleExample

TestAccComputeFirewallPolicyRule_multipleRules

TestAccComputeFirewallPolicyRule_securityProfileGroup_update

TestAccComputeFirewallPolicyRule_update

Get to know how VCR tests work

modular-magician · 2024-08-09T23:46:14Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeFirewallPolicyRule_firewallPolicyRuleExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_securityProfileGroup_update[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

mmv1/products/compute/FirewallPolicyRule.yaml

modular-magician · 2024-08-12T16:41:46Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1110 insertions(+), 594 deletions(-))
google-beta provider: Diff ( 5 files changed, 1110 insertions(+), 594 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 428 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

Field kind within resource google_compute_firewall_policy_rule was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_firewall_policy_rule (10 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_firewall_policy_rule" "primary" {
  match {
    src_secure_tags {
      name = # value needed
    }
  }
  rule_name = # value needed
  target_secure_tags {
    name = # value needed
  }
  tls_inspect = # value needed
}

Errors

google provider:

The diff processor failed to build. This is usually due to the downstream provider failing to compile.

modular-magician · 2024-08-12T17:00:02Z

Tests analytics

Total tests: 979
Passed tests: 902
Skipped tests: 72
Affected tests: 5

Click here to see the affected service packages

compute

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeFirewallPolicyRule_firewallPolicyRuleExample

TestAccComputeFirewallPolicyRule_multipleRules

TestAccComputeFirewallPolicyRule_securityProfileGroup_update

TestAccComputeFirewallPolicyRule_update

TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy

Get to know how VCR tests work

modular-magician · 2024-08-12T17:07:43Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeFirewallPolicyRule_firewallPolicyRuleExample[Debug log]
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_securityProfileGroup_update[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

modular-magician · 2024-08-14T00:56:38Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1123 insertions(+), 597 deletions(-))
google-beta provider: Diff ( 5 files changed, 1123 insertions(+), 597 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 428 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

Field kind within resource google_compute_firewall_policy_rule was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_firewall_policy_rule (10 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_firewall_policy_rule" "primary" {
  match {
    src_secure_tags {
      name = # value needed
    }
  }
  rule_name = # value needed
  target_secure_tags {
    name = # value needed
  }
  tls_inspect = # value needed
}

Errors

google provider:

The diff processor failed to build. This is usually due to the downstream provider failing to compile.

modular-magician · 2024-08-14T01:11:46Z

Tests analytics

Total tests: 980
Passed tests: 902
Skipped tests: 72
Affected tests: 6

Click here to see the affected service packages

compute

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeDisk_storagePoolSpecified

TestAccComputeFirewallPolicyRule_firewallPolicyRuleExample

TestAccComputeFirewallPolicyRule_multipleRules

TestAccComputeFirewallPolicyRule_securityProfileGroup_update

TestAccComputeFirewallPolicyRule_update

TestAccComputeInstance_bootDisk_storagePoolSpecified

Get to know how VCR tests work

modular-magician · 2024-08-14T01:16:30Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeFirewallPolicyRule_firewallPolicyRuleExample[Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Debug log]
TestAccComputeFirewallPolicyRule_securityProfileGroup_update[Debug log]
TestAccComputeFirewallPolicyRule_update[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeDisk_storagePoolSpecified[Error message] [Debug log]
TestAccComputeInstance_bootDisk_storagePoolSpecified[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

github-actions · 2024-08-15T09:40:54Z

@BBBmau This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

BBBmau · 2024-08-15T16:30:42Z

/gcbrun

github-actions · 2024-08-19T09:40:49Z

@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

Samir-Cit · 2024-08-21T14:37:35Z

/gcbrun

@BBBmau this command is working?
Looks like it didn't execute any check.

modular-magician · 2024-08-21T15:16:06Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1123 insertions(+), 597 deletions(-))
google-beta provider: Diff ( 5 files changed, 1123 insertions(+), 597 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 428 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

Field kind within resource google_compute_firewall_policy_rule was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_firewall_policy_rule (10 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_firewall_policy_rule" "primary" {
  match {
    src_secure_tags {
      name = # value needed
    }
  }
  rule_name = # value needed
  target_secure_tags {
    name = # value needed
  }
  tls_inspect = # value needed
}

Errors

google provider:

The diff processor failed to build. This is usually due to the downstream provider failing to compile.

modular-magician · 2024-10-29T22:48:06Z

🟢 Tests passed during RECORDING mode:
TestAccComputeAddress_instanceWithIpExample [Debug log]
TestAccComputeAttachedDisk_basic [Debug log]
TestAccComputeAttachedDisk_count [Debug log]
TestAccComputeAttachedDisk_full [Debug log]
TestAccComputeAttachedDisk_region [Debug log]
TestAccComputeAttachedDisk_zoneless [Debug log]
TestAccComputeBackendService_withMaxConnectionsPerEndpoint [Debug log]
TestAccComputeBackendService_withMaxRatePerEndpoint [Debug log]
TestAccComputeDisk_deleteDetach [Debug log]
TestAccComputeDisk_multiWriter [Debug log]
TestAccComputeFirewallPolicyRule_basic [Debug log]
TestAccComputeFirewallPolicyRule_firewallPolicyRuleExample [Debug log]
TestAccComputeFirewallPolicyRule_multipleRules [Debug log]
TestAccComputeFirewallPolicyRule_securityProfileGroup_update [Debug log]
TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample [Debug log]
TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample [Debug log]
TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate [Debug log]
TestAccComputeGlobalForwardingRule_globalInternalHttpLbWithMigBackendExample [Debug log]
TestAccComputeImageIamBindingGenerated [Debug log]
TestAccComputeImageIamBindingGenerated_withCondition [Debug log]
TestAccComputeImageIamMemberGenerated [Debug log]
TestAccComputeImageIamMemberGenerated_withCondition [Debug log]
TestAccComputeImageIamPolicyGenerated [Debug log]
TestAccComputeImageIamPolicyGenerated_withCondition [Debug log]
TestAccComputeImage_imageBasicExample [Debug log]
TestAccComputeImage_imageBasicStorageLocationExample [Debug log]
TestAccComputeImage_imageGuestOsExample [Debug log]
TestAccComputeImage_update [Debug log]
TestAccComputeInstanceConfidentialInstanceConfigMain [Debug log]
TestAccComputeInstanceFromMachineImageWithOverride_localSsdRecoveryTimeout [Debug log]
TestAccComputeInstanceFromMachineImageWithOverride_partnerMetadata [Debug log]
TestAccComputeInstanceFromMachineImage_basic [Debug log]
TestAccComputeInstanceFromMachineImage_confidentialInstanceConfigMain [Debug log]
TestAccComputeInstanceFromMachineImage_diffProject [Debug log]
TestAccComputeInstanceFromMachineImage_localSsdRecoveryTimeout [Debug log]
TestAccComputeInstanceFromMachineImage_maxRunDuration [Debug log]
TestAccComputeInstanceFromMachineImage_overrideMetadataDotStartupScript [Debug log]
TestAccComputeInstanceFromTemplate_confidentialInstanceConfigMain [Debug log]
TestAccComputeInstanceGroup_basic [Debug log]
TestAccComputeInstanceGroup_network [Debug log]
TestAccComputeInstanceGroup_outOfOrderInstances [Debug log]
TestAccComputeInstanceGroup_rename [Debug log]
TestAccComputeInstanceGroup_update [Debug log]
TestAccComputeInstanceIamBindingGenerated [Debug log]
TestAccComputeInstanceIamBindingGenerated_withCondition [Debug log]
TestAccComputeInstanceIamMemberGenerated [Debug log]
TestAccComputeInstanceIamMemberGenerated_withCondition [Debug log]
TestAccComputeInstanceIamPolicy [Debug log]
TestAccComputeInstanceIamPolicyGenerated [Debug log]
TestAccComputeInstanceIamPolicyGenerated_withCondition [Debug log]
TestAccComputeInstanceTemplate_AdvancedMachineFeatures [Debug log]
TestAccComputeInstanceTemplate_ConfidentialInstanceConfigMain [Debug log]
TestAccComputeInstanceTemplate_imageShorthand [Debug log]
TestAccComputeInstanceTemplate_nictype_update [Debug log]
TestAccComputeInstance_IP [Debug log]
TestAccComputeInstance_IPv6 [Debug log]
TestAccComputeInstance_NetworkAttachment [Debug log]
TestAccComputeInstance_NetworkAttachmentUpdate [Debug log]
TestAccComputeInstance_NicStackTypeUpdate [Debug log]
TestAccComputeInstance_PTRRecord [Debug log]
TestAccComputeInstance_advancedMachineFeatures [Debug log]
TestAccComputeInstance_aliasIpRangeCommonAddresses [Debug log]
TestAccComputeInstance_attachedDisk [Debug log]
TestAccComputeInstance_attachedDiskUpdate [Debug log]
TestAccComputeInstance_attachedDisk_modeRo [Debug log]
TestAccComputeInstance_attachedDisk_sourceUrl [Debug log]
TestAccComputeInstance_basic2 [Debug log]
TestAccComputeInstance_basic3 [Debug log]
TestAccComputeInstance_basic4 [Debug log]
TestAccComputeInstance_basic5 [Debug log]
TestAccComputeInstance_bootDisk_mode [Debug log]
TestAccComputeInstance_bootDisk_source [Debug log]
TestAccComputeInstance_bootDisk_sourceUrl [Debug log]
TestAccComputeInstance_bootDisk_type [Debug log]
TestAccComputeInstance_confidentialHyperDiskBootDisk [Debug log]
TestAccComputeInstance_deletionProtectionExplicitFalse [Debug log]
TestAccComputeInstance_deletionProtectionExplicitTrueAndUpdateFalse [Debug log]
TestAccComputeInstance_descriptionUpdate [Debug log]
TestAccComputeInstance_desiredStatusTerminatedUpdateFields [Debug log]
TestAccComputeInstance_desiredStatusUpdateBasic [Debug log]
TestAccComputeInstance_diskEncryption [Debug log]
TestAccComputeInstance_diskEncryptionRestart [Debug log]
TestAccComputeInstance_enableDisplay [Debug log]
TestAccComputeInstance_forceNewAndChangeMetadata [Debug log]
TestAccComputeInstance_guestAccelerator [Debug log]
TestAccComputeInstance_guestAcceleratorSkip [Debug log]
TestAccComputeInstance_hostname [Debug log]
TestAccComputeInstance_hyperdiskBootDisk_provisioned_iops_throughput [Debug log]
TestAccComputeInstance_internalIPv6 [Debug log]
TestAccComputeInstance_ipv6ExternalReservation [Debug log]
TestAccComputeInstance_kmsDiskEncryption [Debug log]
TestAccComputeInstance_localSsdRecoveryTimeout [Debug log]
TestAccComputeInstance_localSsdRecoveryTimeout_update [Debug log]
TestAccComputeInstance_localSsdVM_maxRunDuration_stopTerminationAction [Debug log]
TestAccComputeInstance_machineTypeUrl [Debug log]
TestAccComputeInstance_metadataStartupScript_update [Debug log]
TestAccComputeInstance_minCpuPlatform [Debug log]
TestAccComputeInstance_multiNic [Debug log]
TestAccComputeInstance_networkIPAuto [Debug log]
TestAccComputeInstance_networkIpUpdate [Debug log]
TestAccComputeInstance_networkPerformanceConfig [Debug log]
TestAccComputeInstance_networkTier [Debug log]
TestAccComputeInstance_network_ip_custom [Debug log]
TestAccComputeInstance_nictype_update [Debug log]
TestAccComputeInstance_noServiceAccount [Debug log]
TestAccComputeInstance_partnerMetadata [Debug log]
TestAccComputeInstance_partnerMetadata_deletePartnerMetadata [Debug log]
TestAccComputeInstance_partnerMetadata_update [Debug log]
TestAccComputeInstance_primaryAliasIpRange [Debug log]
TestAccComputeInstance_private_image_family [Debug log]
TestAccComputeInstance_queueCount [Debug log]
TestAccComputeInstance_regionBootDisk [Debug log]
TestAccComputeInstance_reservationAffinities [Debug log]
TestAccComputeInstance_resourceManagerTags [Debug log]
TestAccComputeInstance_resourcePolicyCollocate [Debug log]
TestAccComputeInstance_resourcePolicyUpdate [Debug log]
TestAccComputeInstance_secondaryAliasIpRange [Debug log]
TestAccComputeInstance_serviceAccount [Debug log]
TestAccComputeInstance_serviceAccountEmail_0scopes [Debug log]
TestAccComputeInstance_serviceAccount_updated [Debug log]
TestAccComputeInstance_serviceAccount_updated0to1to0scopes [Debug log]
TestAccComputeInstance_shieldedVmConfig [Debug log]
TestAccComputeInstance_soleTenantNodeAffinities [Debug log]
TestAccComputeInstance_spotVM [Debug log]
TestAccComputeInstance_spotVM_maxRunDuration_deleteTerminationAction [Debug log]
TestAccComputeInstance_spotVM_maxRunDuration_update [Debug log]
TestAccComputeInstance_spotVM_update [Debug log]
TestAccComputeInstance_standardVM_maxRunDuration_deleteTerminationAction [Debug log]
TestAccComputeInstance_standardVM_maxRunDuration_stopTerminationAction [Debug log]
TestAccComputeInstance_stopInstanceToUpdate [Debug log]
TestAccComputeInstance_subnet_auto [Debug log]
TestAccComputeInstance_subnet_custom [Debug log]
TestAccComputeInstance_subnetworkUpdate [Debug log]
TestAccComputeInstance_updateRunning_desiredStatusNotSet_notAllowStoppingForUpdate [Debug log]
TestAccComputeInstance_updateRunning_desiredStatusRunning_allowStoppingForUpdate [Debug log]
TestAccComputeInstance_updateRunning_desiredStatusRunning_notAllowStoppingForUpdate [Debug log]
TestAccComputeInstance_updateRunning_desiredStatusTerminated_allowStoppingForUpdate [Debug log]
TestAccComputeInstance_updateRunning_desiredStatusTerminated_notAllowStoppingForUpdate [Debug log]
TestAccComputeInstance_updateTerminated_desiredStatusNotSet_allowStoppingForUpdate [Debug log]
TestAccComputeInstance_updateTerminated_desiredStatusNotSet_notAllowStoppingForUpdate [Debug log]
TestAccComputeInstance_updateTerminated_desiredStatusRunning_allowStoppingForUpdate [Debug log]
TestAccComputeInstance_updateTerminated_desiredStatusRunning_notAllowStoppingForUpdate [Debug log]
TestAccComputeInstance_updateTerminated_desiredStatusTerminated_allowStoppingForUpdate [Debug log]
TestAccComputeInstance_updateTerminated_desiredStatusTerminated_notAllowStoppingForUpdate [Debug log]
TestAccComputeInstance_with375GbScratchDisk [Debug log]
TestAccComputeMachineImageIamBindingGenerated [Debug log]
TestAccComputeMachineImageIamBindingGenerated_withCondition [Debug log]
TestAccComputeMachineImageIamMemberGenerated [Debug log]
TestAccComputeMachineImageIamMemberGenerated_withCondition [Debug log]
TestAccComputeMachineImageIamPolicyGenerated [Debug log]
TestAccComputeMachineImageIamPolicyGenerated_withCondition [Debug log]
TestAccComputeMachineImage_computeMachineImageKmsExample [Debug log]
TestAccComputeMachineImage_machineImageBasicExample [Debug log]
TestAccComputeNetworkAttachment_networkAttachmentInstanceUsageExample [Debug log]
TestAccComputeNetworkEndpointGroup_internalEndpoint [Debug log]
TestAccComputeNetworkFirewallPolicyRule_securityProfileGroup_update [Debug log]
TestAccComputeNetworkFirewallPolicyRule_update [Debug log]
TestAccComputePacketMirroring_computePacketMirroringFullExample [Debug log]
TestAccComputeProjectMetadata_basic [Debug log]
TestAccComputeProjectMetadata_modify_1 [Debug log]
TestAccComputeProjectMetadata_modify_2 [Debug log]
TestAccComputeRegionBackendService_ilbUpdateFull [Debug log]
TestAccComputeRegionInstanceTemplate_AdvancedMachineFeatures [Debug log]
TestAccComputeRegionInstanceTemplate_ConfidentialInstanceConfigMain [Debug log]
TestAccComputeRegionInstanceTemplate_imageShorthand [Debug log]
TestAccComputeRegionInstanceTemplate_nictype_update [Debug log]
TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupAppengineExample [Debug log]
TestAccComputeRegionNetworkEndpoint_regionNetworkEndpointPortmapExample [Debug log]
TestAccComputeResourcePolicy_attached [Debug log]
TestAccComputeRoute_hopInstance [Debug log]
TestAccComputeRouterBgpPeer_routerPeerRouterAppliance [Debug log]
TestAccComputeRouterPeer_routerApplianceInstance [Debug log]
TestAccComputeTargetInstance_targetInstanceBasicExample [Debug log]
TestAccComputeTargetInstance_targetInstanceCustomNetworkExample [Debug log]
TestAccComputeTargetInstance_targetInstanceWithSecurityPolicyExample [Debug log]
TestAccComputeTargetInstance_withSecurityPolicy [Debug log]
TestAccComputeTargetPool_basic [Debug log]
TestAccComputeTargetPool_update [Debug log]
TestAccComputeUrlMap_urlMapCustomErrorResponsePolicyExample [Debug log]
TestAccDataSourceComputeInstanceSerialPort_basic [Debug log]
TestAccDataSourceComputeInstance_basic [Debug log]
TestAccDataSourceComputeInstance_networkAttachmentUsageExample [Debug log]
TestAccDataSourceGoogleComputeInstanceGroup_basic [Debug log]
TestAccDataSourceGoogleComputeInstanceGroup_withNamedPort [Debug log]
TestAccRegionInstanceGroupManager_distributionPolicy [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccComputeFirewallPolicyRule_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-10-30T16:22:22Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1078 insertions(+), 578 deletions(-))
google-beta provider: Diff ( 6 files changed, 1078 insertions(+), 578 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 346 insertions(+))

Errors

google provider:

The diff processor failed to build. This is usually due to the downstream provider failing to compile.

modular-magician · 2024-10-30T16:40:30Z

Tests analytics

Total tests: 1049
Passed tests: 973
Skipped tests: 73
Affected tests: 3

Click here to see the affected service packages

compute

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeFirewallPolicyRule_multipleRules

TestAccComputeFirewallPolicyRule_securityProfileGroup_update

TestAccComputeFirewallPolicyRule_update

Get to know how VCR tests work

modular-magician · 2024-10-30T16:44:43Z

🟢 Tests passed during RECORDING mode:
TestAccComputeFirewallPolicyRule_multipleRules [Debug log]
TestAccComputeFirewallPolicyRule_securityProfileGroup_update [Debug log]
TestAccComputeFirewallPolicyRule_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

modular-magician · 2024-10-30T17:32:07Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 206 insertions(+), 100 deletions(-))
google-beta provider: Diff ( 6 files changed, 1081 insertions(+), 579 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 346 insertions(+))

modular-magician · 2024-10-30T17:51:25Z

Tests analytics

Total tests: 1049
Passed tests: 975
Skipped tests: 73
Affected tests: 1

Click here to see the affected service packages

compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeFirewallPolicyRule_firewallPolicyRuleExample

Get to know how VCR tests work

modular-magician · 2024-10-30T17:51:38Z

🔴 Tests failed during RECORDING mode:
TestAccComputeFirewallPolicyRule_firewallPolicyRuleExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-10-30T21:34:33Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 214 insertions(+), 100 deletions(-))
google-beta provider: Diff ( 6 files changed, 1097 insertions(+), 579 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 346 insertions(+))

modular-magician · 2024-10-30T21:53:20Z

Tests analytics

Total tests: 1049
Passed tests: 975
Skipped tests: 73
Affected tests: 1

Click here to see the affected service packages

compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy

Get to know how VCR tests work

modular-magician · 2024-10-30T22:02:33Z

🟢 Tests passed during RECORDING mode:
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

…GoogleCloudPlatform#11360) Co-authored-by: Thomas Rodgers <thomasrodgers@google.com>

modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Aug 5, 2024

Samir-Cit changed the title ~~Move google_compute_firewall_policy_ruleresource from DCL to MMv1~~ Move google_compute_firewall_policy_rule resource from DCL to MMv1 Aug 5, 2024

Samir-Cit marked this pull request as ready for review August 9, 2024 22:18

github-actions bot requested a review from BBBmau August 9, 2024 22:19

modular-magician added service/network-security-distributed-firewall and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Aug 9, 2024

BBBmau reviewed Aug 10, 2024

View reviewed changes

mmv1/products/compute/FirewallPolicyRule.yaml Outdated Show resolved Hide resolved

github-actions bot requested a review from BBBmau August 12, 2024 15:57

modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Aug 12, 2024

modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Aug 13, 2024

modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Aug 15, 2024

Samir-Cit changed the title ~~Move google_compute_firewall_policy_rule resource from DCL to MMv1~~ Migrate google_compute_firewall_policy_rule resource from DCL to MMv1 Aug 19, 2024

modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Aug 21, 2024

Samir-Cit added 3 commits October 29, 2024 23:11

Refactoring

d71eb24

Refactoring

7921f65

Fix target* fields and update test

9bd3a2b

modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Oct 30, 2024

Resource is still in beta

2671579

modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Oct 30, 2024

Resource is still in beta

1d565d2

modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Oct 30, 2024

Beta example

5f84565

modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Oct 30, 2024

trodge approved these changes Nov 1, 2024

View reviewed changes

trodge merged commit c733f35 into GoogleCloudPlatform:main Nov 1, 2024
14 checks passed

BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Nov 5, 2024

Migrate google_compute_firewall_policy_rule resource from DCL to MMv1 (…

6303539

…GoogleCloudPlatform#11360) Co-authored-by: Thomas Rodgers <thomasrodgers@google.com>

akshat-jindal-nit pushed a commit to akshat-jindal-nit/magic-modules that referenced this pull request Nov 18, 2024

Migrate google_compute_firewall_policy_rule resource from DCL to MMv1 (…

ba527d5

…GoogleCloudPlatform#11360) Co-authored-by: Thomas Rodgers <thomasrodgers@google.com>

amanMahendroo pushed a commit to amanMahendroo/magic-modules that referenced this pull request Dec 17, 2024

Migrate google_compute_firewall_policy_rule resource from DCL to MMv1 (…

a34aa28

…GoogleCloudPlatform#11360) Co-authored-by: Thomas Rodgers <thomasrodgers@google.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate google_compute_firewall_policy_rule resource from DCL to MMv1 #11360

Migrate google_compute_firewall_policy_rule resource from DCL to MMv1 #11360

Samir-Cit commented Aug 5, 2024 •

edited

Loading

github-actions bot commented Aug 9, 2024

modular-magician commented Aug 9, 2024

modular-magician commented Aug 9, 2024

modular-magician commented Aug 9, 2024

modular-magician commented Aug 12, 2024

modular-magician commented Aug 12, 2024

modular-magician commented Aug 12, 2024

modular-magician commented Aug 14, 2024

modular-magician commented Aug 14, 2024

modular-magician commented Aug 14, 2024

github-actions bot commented Aug 15, 2024

BBBmau commented Aug 15, 2024

github-actions bot commented Aug 19, 2024

Samir-Cit commented Aug 21, 2024

modular-magician commented Aug 21, 2024

modular-magician commented Oct 29, 2024

modular-magician commented Oct 30, 2024

modular-magician commented Oct 30, 2024

modular-magician commented Oct 30, 2024

modular-magician commented Oct 30, 2024

modular-magician commented Oct 30, 2024

modular-magician commented Oct 30, 2024

modular-magician commented Oct 30, 2024

modular-magician commented Oct 30, 2024

modular-magician commented Oct 30, 2024

Migrate google_compute_firewall_policy_rule resource from DCL to MMv1 #11360

Migrate google_compute_firewall_policy_rule resource from DCL to MMv1 #11360

Conversation

Samir-Cit commented Aug 5, 2024 • edited Loading

github-actions bot commented Aug 9, 2024

modular-magician commented Aug 9, 2024

Diff report

Breaking Change(s) Detected

Missing test report

Errors

modular-magician commented Aug 9, 2024

Tests analytics

Action taken

modular-magician commented Aug 9, 2024

modular-magician commented Aug 12, 2024

Diff report

Breaking Change(s) Detected

Missing test report

Errors

modular-magician commented Aug 12, 2024

Tests analytics

Action taken

modular-magician commented Aug 12, 2024

modular-magician commented Aug 14, 2024

Diff report

Breaking Change(s) Detected

Missing test report

Errors

modular-magician commented Aug 14, 2024

Tests analytics

Action taken

modular-magician commented Aug 14, 2024

github-actions bot commented Aug 15, 2024

BBBmau commented Aug 15, 2024

github-actions bot commented Aug 19, 2024

Samir-Cit commented Aug 21, 2024

modular-magician commented Aug 21, 2024

Diff report

Breaking Change(s) Detected

Missing test report

Errors

modular-magician commented Oct 29, 2024

modular-magician commented Oct 30, 2024

Diff report

Errors

modular-magician commented Oct 30, 2024

Tests analytics

Action taken

modular-magician commented Oct 30, 2024

modular-magician commented Oct 30, 2024

Diff report

modular-magician commented Oct 30, 2024

Tests analytics

Action taken

modular-magician commented Oct 30, 2024

modular-magician commented Oct 30, 2024

Diff report

modular-magician commented Oct 30, 2024

Tests analytics

Action taken

modular-magician commented Oct 30, 2024

Samir-Cit commented Aug 5, 2024 •

edited

Loading