Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding labels based on downstreams created #1149

Merged
merged 3 commits into from
Jan 8, 2019
Merged

Adding labels based on downstreams created #1149

merged 3 commits into from
Jan 8, 2019

Conversation

rambleraptor
Copy link
Contributor

This fixes #124 and will help us build great changelogs for Ansible

[all]

[terraform]

[terraform-beta]

[ansible]

[inspec]

nat-henderson
nat-henderson reviewed Jan 3, 2019
View reviewed changes
.ci/magic-modules/create-pr.sh
@@ -51,6 +52,7 @@ if [ "$BRANCH_NAME" = "$ORIGINAL_PR_BRANCH" ]; then
git checkout -b "$BRANCH_NAME"
if TF_PR=$(hub pull-request -b "$TERRAFORM_REPO_USER/$PROVIDER_NAME:master" -F ./downstream_body); then
DEPENDENCIES="${DEPENDENCIES}depends: $TF_PR ${NEWLINE}"
LABELS="${LABELS}${PROVIDER_NAME},"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$PROVIDER_NAME is terraform-provider-google-beta - you want $SUBMODULE_DIR, which is google-beta.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we want the label to be "terraform-provider-google-beta" and not "google-beta"?

.ci/magic-modules/create-pr.sh Outdated
@@ -112,6 +117,13 @@ $DEPENDENCIES
EOF
fi

# Create Labels list with the comma-separated list of labels for this PR
if [ -z "$LABELS" ]; then
echo $LABELS > ./label_file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is going to produce an empty-string value at the end of the list, right? since the list will end with a comma and we parse it with .split(',')?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated it to follow the cat/EOF model you did for pr comments. Does this look better?

@modular-magician
Copy link
Collaborator

I am a robot that works on MagicModules PRs!
I checked the downstream repositories (see README.md for which ones I can write to), and none of them seem to have any changes.

Once this PR is approved, you can feel free to merge it without taking any further steps.

@rambleraptor rambleraptor force-pushed the magician-add-labels branch 2 times, most recently from 655f7b0 to 78e7500 Compare January 3, 2019 22:07
@modular-magician
Copy link
Collaborator

I am a robot that works on MagicModules PRs!
I checked the downstream repositories (see README.md for which ones I can write to), and none of them seem to have any changes.

Once this PR is approved, you can feel free to merge it without taking any further steps.

@rambleraptor
Copy link
Contributor Author

@ndmckinley I finally figured out how to Bash, so take a look

@nat-henderson
Copy link
Contributor

Huh, does that work better? Basically I'm asking "won't this add an empty-string label to every PR?" and if the answer is no, I've misread it, go ahead and submit! :)

@modular-magician
Copy link
Collaborator

I am a robot that works on MagicModules PRs!
I checked the downstream repositories (see README.md for which ones I can write to), and none of them seem to have any changes.

Once this PR is approved, you can feel free to merge it without taking any further steps.

1 similar comment
@modular-magician
Copy link
Collaborator

I am a robot that works on MagicModules PRs!
I checked the downstream repositories (see README.md for which ones I can write to), and none of them seem to have any changes.

Once this PR is approved, you can feel free to merge it without taking any further steps.

@rambleraptor rambleraptor force-pushed the magician-add-labels branch 2 times, most recently from c5b6319 to 6c6f9c2 Compare January 4, 2019 00:51
@modular-magician
Copy link
Collaborator

I am a robot that works on MagicModules PRs!
I checked the downstream repositories (see README.md for which ones I can write to), and none of them seem to have any changes.

Once this PR is approved, you can feel free to merge it without taking any further steps.

@modular-magician
Copy link
Collaborator

I am a robot that works on MagicModules PRs!
I checked the downstream repositories (see README.md for which ones I can write to), and none of them seem to have any changes.

Once this PR is approved, you can feel free to merge it without taking any further steps.

@modular-magician
Copy link
Collaborator

I am a robot that works on MagicModules PRs!
I checked the downstream repositories (see README.md for which ones I can write to), and none of them seem to have any changes.

Once this PR is approved, you can feel free to merge it without taking any further steps.

@modular-magician
Copy link
Collaborator

I am a robot that works on MagicModules PRs!
I checked the downstream repositories (see README.md for which ones I can write to), and none of them seem to have any changes.

Once this PR is approved, you can feel free to merge it without taking any further steps.

@modular-magician
Copy link
Collaborator

I am a robot that works on MagicModules PRs!
I checked the downstream repositories (see README.md for which ones I can write to), and none of them seem to have any changes.

Once this PR is approved, you can feel free to merge it without taking any further steps.

@rambleraptor rambleraptor force-pushed the magician-add-labels branch 2 times, most recently from 6220aee to 55876df Compare January 8, 2019 00:00
@modular-magician
Copy link
Collaborator

modular-magician commented Jan 8, 2019 •
edited by rambleraptor
Loading

I am a robot that works on MagicModules PRs!

I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed.

@modular-magician modular-magician merged commit e5baf7d into master Jan 8, 2019
This was referenced Jan 9, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nat-henderson nat-henderson nat-henderson approved these changes

Assignees
No one assigned
Labels
ansible automerged cla: yes downstream-generated terraform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add labels to PR based on which provider it affects
4 participants
@rambleraptor @modular-magician @nat-henderson @googlebot