tweaks to convert-go.sh #11762
Merged
tweaks to convert-go.sh #11762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c2thorn
force-pushed
the
rewrite-convert-scripts
branch
from
5823caa to
8942909
Compare
c2thorn
merged commit 935e62d
into
GoogleCloudPlatform:rewrite-script-updates
3 of 4 checks passed
c2thorn
added a commit
to c2thorn/magic-modules
that referenced
this pull request
Sep 24, 2024
…tchover-preview * rewrite-script-updates: remove newline remove "already modified" error rewrite - script tweaks to replace path and QoL branching tweaks to convert-go.sh (GoogleCloudPlatform#11762)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
convert-go.sh runs in root directory, not in mmv1/ folder. Makes it consistent with cherry-pick.sh
Also can handle relative or absolute template files.
Directions are now:
scripts/convert-go.shdoes the conversion in a pre-switchover commit and outputs the converted files to *.temp files.Example command in the root MM directory (in a pre-switchover commit)
scripts/cherry-pick.shprepares a new branch in a post-switchover commit and cherry-picks the previous *.temp filesExample command from root MM directory