Add parameters to google_org_policy_policy

[nehalk-tf]

Release Note Template for Downstream PRs (will be copied)

orgpolicy: added `parameters` fields to `google_org_policy_policy` resource (beta)

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 35 insertions(+))
google-beta provider: Diff ( 2 files changed, 126 insertions(+), 10 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 39 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_org_policy_policy (9 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_org_policy_policy" "primary" {
  dry_run_spec {
    rules {
      parameters = # value needed
    }
  }
  spec {
    rules {
      parameters = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 8
Passed tests: 8
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• orgpolicy

🟢 All tests passed!

View the build log

[github-actions]

@c2thorn This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[c2thorn]

running the build

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 63 insertions(+))
google-beta provider: Diff ( 3 files changed, 154 insertions(+), 10 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 39 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_org_policy_policy (9 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_org_policy_policy" "primary" {
  dry_run_spec {
    rules {
      parameters = # value needed
    }
  }
  spec {
    rules {
      parameters = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 8
Passed tests: 8
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• orgpolicy

🟢 All tests passed!

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 140 insertions(+))
google-beta provider: Diff ( 3 files changed, 231 insertions(+), 10 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 39 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_org_policy_policy (9 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_org_policy_policy" "primary" {
  dry_run_spec {
    rules {
      parameters = # value needed
    }
  }
  spec {
    rules {
      parameters = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 10
Passed tests: 8
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

• orgpolicy

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccOrgPolicyPolicy_EnforceParameterizedMCDryRunPolicy
• TestAccOrgPolicyPolicy_EnforceParameterizedMCPolicy

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccOrgPolicyPolicy_EnforceParameterizedMCDryRunPolicy [Error message] [Debug log]
TestAccOrgPolicyPolicy_EnforceParameterizedMCPolicy [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[github-actions]

@GoogleCloudPlatform/terraform-team @c2thorn This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 131 insertions(+))
google-beta provider: Diff ( 3 files changed, 222 insertions(+), 10 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 39 insertions(+))

[modular-magician]

Tests analytics

Total tests: 10
Passed tests: 8
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

• orgpolicy

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccOrgPolicyPolicy_EnforceParameterizedMCDryRunPolicy
• TestAccOrgPolicyPolicy_EnforceParameterizedMCPolicy

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccOrgPolicyPolicy_EnforceParameterizedMCDryRunPolicy [Error message] [Debug log]
TestAccOrgPolicyPolicy_EnforceParameterizedMCPolicy [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 131 insertions(+))
google-beta provider: Diff ( 3 files changed, 222 insertions(+), 10 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 39 insertions(+))

[modular-magician]

Tests analytics

Total tests: 10
Passed tests: 8
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

• orgpolicy

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccOrgPolicyPolicy_EnforceParameterizedMCDryRunPolicy
• TestAccOrgPolicyPolicy_EnforceParameterizedMCPolicy

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccOrgPolicyPolicy_EnforceParameterizedMCDryRunPolicy [Error message] [Debug log]
TestAccOrgPolicyPolicy_EnforceParameterizedMCPolicy [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[github-actions]

@GoogleCloudPlatform/terraform-team @c2thorn This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[c2thorn]

disabling review reminders while tests are failing

[nehalk-tf]

Conducted manual testing in the staging environment due to the absence of production constraints that are necessary for automated Terraform tests.

Create resource terraform logs: https://paste.googleplex.com/6345233051418624
Verified updated resource in pantheon: https://screenshot.googleplex.com/7b8k7zi2rpfLAHh

Update resource terraform logs: https://paste.googleplex.com/6661042600673280
Verified updated resource in pantheon: https://screenshot.googleplex.com/5mnQYdPe3p7nBn6

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 225 insertions(+), 10 deletions(-))
google-beta provider: Diff ( 3 files changed, 225 insertions(+), 10 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 39 insertions(+))

[modular-magician]

Tests analytics

Total tests: 10
Passed tests: 8
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages

• orgpolicy

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

• TestAccOrgPolicyPolicy_EnforceParameterizedMCDryRunPolicy
• TestAccOrgPolicyPolicy_EnforceParameterizedMCPolicy
  🟢 All tests passed!

View the build log