Add support for global application in Apphub

[eshagoel06]

Add support for global application and validation for location and scope type
FIXES hashicorp/terraform-provider-google#19252

Release Note Template for Downstream PRs (will be copied)

apphub: added `GLOBAL` enum value to `scope.type` field in `google_apphub_application` resource

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 85 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 3 files changed, 85 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 22 insertions(+))
Open in Cloud Shell: Diff ( 5 files changed, 110 insertions(+), 2 deletions(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 85 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 3 files changed, 85 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 22 insertions(+))
Open in Cloud Shell: Diff ( 5 files changed, 110 insertions(+), 2 deletions(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 85 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 3 files changed, 85 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 22 insertions(+))
Open in Cloud Shell: Diff ( 5 files changed, 110 insertions(+), 2 deletions(-))

[modular-magician]

Tests analytics

Total tests: 14
Passed tests: 13
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• apphub

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccApphubApplication_applicationGlobalBasicExample

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccApphubApplication_applicationGlobalBasicExample[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[modular-magician]

Tests analytics

Total tests: 14
Passed tests: 13
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• apphub

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccApphubApplication_applicationGlobalBasicExample

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccApphubApplication_applicationGlobalBasicExample[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[modular-magician]

Tests analytics

Total tests: 14
Passed tests: 14
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• apphub

🟢 All tests passed!

View the build log

[c2thorn]

Would the API give an appropriate error in this case? If so, is there a particular pressure to duplicate this validation in the Terraform provider?

Adding additional validation at this level can lead to instances where the API requirements change but the Terraform providers lag behind.

[eshagoel06]

API will give an appropriate error in such case. But we wanted terraform plan to perform validation and catch this error.

[c2thorn]

we should cover this logic somewhere in a test. If we are going to keep it (see my previous comment), let's add an invalid config in https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/third_party/terraform/services/apphub/resource_apphub_application_test.go and use ExpectError

[eshagoel06]

Done

[c2thorn]

is config_path actually necessary here? This is usually just used in for private overrides. I'm assuming other examples of using this were just accidentally copied over from the private repo

[eshagoel06]

Have updated basic and full examples to remove config_path. But for *_global_basic , we were intending to use the same config as basic with different values.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 147 insertions(+), 16 deletions(-))
google-beta provider: Diff ( 4 files changed, 147 insertions(+), 16 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 22 insertions(+))
Open in Cloud Shell: Diff ( 12 files changed, 346 insertions(+))

[modular-magician]

Tests analytics

Total tests: 15
Passed tests: 11
Skipped tests: 0
Affected tests: 4

Click here to see the affected service packages

• apphub

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccApphubApplication_apphubApplicationBasicExample
• TestAccApphubApplication_apphubApplicationFullExample
• TestAccApphubApplication_apphubApplicationGlobalBasicExample
• TestAccApphubApplication_invalidConfigFails

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccApphubApplication_apphubApplicationBasicExample [Debug log]
TestAccApphubApplication_apphubApplicationFullExample [Debug log]
TestAccApphubApplication_apphubApplicationGlobalBasicExample [Debug log]
TestAccApphubApplication_invalidConfigFails [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[github-actions]

@c2thorn This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.