Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

promote netapp regional flex storage pool and volume to GA #12082

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

Mehul3217
Copy link
Contributor

@Mehul3217 Mehul3217 commented Oct 22, 2024

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

netapp: promoted `zone` and `replica_zone` fields to GA in `google_netapp_storage_pool` resource
netapp: promoted `zone` and `replica_zone` fields to GA in `google_netapp_volume` resource

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 219 insertions(+), 7 deletions(-))
google-beta provider: Diff ( 3 files changed, 5 insertions(+), 15 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 20
Passed tests: 20
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • netapp
#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

  • TestAccNetappStoragePool_FlexRegionalStoragePoolCreateExample_update
    🟢 All tests passed!

View the build log

@zli82016 zli82016 changed the title promote regional flex to GA promote netapp regional flex storage pool and volume to GA Oct 22, 2024
@zli82016
Copy link
Member

TestAccNetappStoragePool_FlexRegionalStoragePoolCreateExample_update passed in Teamcity

Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants