`ephemeral`: add `ephemeral_google_service_account_access_token` #12140

BBBmau · 2024-10-25T20:29:27Z

An ephemeral resource that mimics the google_service_account_access_token data source

Release Note Template for Downstream PRs (will be copied)

BBBmau · 2024-11-05T03:58:30Z

recent commit addresses some issues, ephemeral resource is now working when running locally

tfconfig:

ephemeral "google_test" "test" {
  target_service_account = "malvarezleon@hc-terraform-testing.iam.gserviceaccount.com"
  scopes = ["https://www.googleapis.com/auth/cloud-platform"]

  lifetime = "10s"
}

debug output:

 POST /v1/projects/-/serviceAccounts/malvarezleon@hc-terraform-testing.iam.gserviceaccount.com:generateAccessToken?alt=json&prettyPrint=false HTTP/1.1
 Host: iamcredentials.googleapis.com
 User-Agent: google-api-go-client/0.5 Terraform/1.10.0-alpha20241023 (+https://www.terraform.io) Terraform-Plugin-SDK/terraform-plugin-framework terraform-provider-google/dev
 Content-Length: 78
 Content-Type: application/json
 X-Goog-Api-Client: gl-go/1.23.2 gdcl/0.193.0
 Accept-Encoding: gzip

 {
  "lifetime": "10s",
  "scope": [
   "https://www.googleapis.com/auth/cloud-platform"
  ]
 }

 -----------------------------------------------------
 2024/11/04 19:41:00 [DEBUG] Google API Response Details:
 ---[ RESPONSE ]--------------------------------------
 HTTP/2.0 200 OK
 Alt-Svc: h3=":443"; ma=2592000,h3-29=":443"; ma=2592000
 Cache-Control: private
 Content-Type: application/json; charset=UTF-8
 Date: Tue, 05 Nov 2024 03:41:00 GMT
 Server: scaffolding on HTTPServer2
 Vary: Origin
 Vary: X-Origin
 Vary: Referer
 X-Content-Type-Options: nosniff
 X-Frame-Options: SAMEORIGIN
 X-Xss-Protection: 0

 {
  "accessToken": "ya29.c.c0ASRK0GZTgneHg5v4KBWZPZLdNFhNsehSCn8hpgW5R91nXQuACK3BoU-PFRmOjO7Pxu0WLoyVyCfso2OKHIO7tlZf38imfQ6WVBl7g8g4bg1WLQvVzSo7z0o_RNHKkfmI0xP5xcboXYXHyYf7jzrwEvBSeSYQDUzxxtHNnzQJmvsdD3GtrEKMpb1gTVv8mckZ59Gsn5MztgCd0THTNHZIkuQAsIeUfnVLoiv17Y8MTBTuQE-rSOPN7X51szH-HULI0efAlnNi7Sic8ws5qHi9FfHUNIxwy9LdHiya7d3-MViYsXL-Qf1VUsG9HLdj9uJric3E5k_yT7vTaG-EwKYw2hkefSQDpN5rPWD0G1XoqDvUOZc4GD1P2ZLvC2JsufcwFTKe9LxBoFZcsZF6fiXzqlzwHMZV9E_LiyWhNdqXtKb8s9w8u0d68B-xIptX6bYMlJoVEVqgs7T7rR9yDEWl9OjaWrtI-LK03vi99OG5AFn44h1676CzJwGclPNhGDdFxI1i1bgFu6nadfQ0OvGJfRTA5Gnn3LYEITnG3iChEuXHepxN2CqL6vQ_pKOVprt5GETTjTmBwBFPMFro4Q3hbQ49EthXzS5lTus6Avg2E625Pbbrutwk3JcreuQv_bwz2bbmFqp-pJ1MrZfO-yimq8mZBte0kxB_IVJgmjjbSvl96JkSr1Rurxn10XWZ7lSkyWM5oe51Mvzi2vvtd332yIcV-dWUZgmV-BvekbJmRVgzzvZbih0tbRucg0I7t201kSV-db7omY4aY-_dZXdx3tfS7j64ZQ0O_-uYFUe3_9kgq3gI1gap4MBeBwte19r8O_-yRw3OmQjlhXZikes_jx2w2qbQIQVq1ee4wU2w8uWBWr9oIrhjRx2rydIBn3SZJQ4foeXpYMdwFJ_h_d9zI-Jbgt9Uwh46ibhu1vUpJW2B-gFhUpyhdmF2mgWWOvnlY6F4ts2rQpF85rRyBgfsQStqZMftM0OQSyhZpgyeQq2VJRp2vZXdsvU",
  "expireTime": "2024-11-05T03:41:10Z"
 }
 -----------------------------------------------------
 2024/11/04 19:41:00 [DEBUG] Retry Transport: Stopping retries, last request was successful
 2024/11/04 19:41:00 [DEBUG] Retry Transport: Returning after 1 attempts

still missing tests, though the ability to test ephemeral resources / values is currently being worked on, this was pushed last friday and will be included in terraform-plugin-testing

an example of how it can be tested can be viewed here: hashicorp/terraform-provider-corner@76f20a3

The echo provider can be found here: hashicorp/terraform-provider-corner@44d5ec0

mmv1/third_party/terraform/services/resourcemanager/ephemeral_google_service_account_token.go

modular-magician · 2024-11-06T01:10:05Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 379 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 3 files changed, 379 insertions(+), 1 deletion(-))

Errors

google provider:

The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

The diff processor failed to build. This is usually due to the downstream provider failing to compile.

modular-magician · 2024-11-06T01:12:54Z

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

SarahFrench

Please rebase your PR on the latest version of FEATURE-BRANCH-ephemeral-resource - this will pull in the dependency updates and fix the build errors showing in this PR.

Also, please move the validator code into the file discussed here.

SarahFrench

Follow up to previous review

mmv1/third_party/terraform/services/resourcemanager/ephemeral_google_service_account_token.go

...hird_party/terraform/services/resourcemanager/ephemeral_google_service_account_token_test.go

mmv1/third_party/terraform/services/resourcemanager/ephemeral_google_service_account_token.go

modular-magician · 2024-11-07T00:22:52Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 380 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 3 files changed, 380 insertions(+), 1 deletion(-))

BBBmau · 2024-11-07T01:09:08Z

tests pass locally however we should consider the fwvalidators package PR before continuing:

=== RUN   TestEphemeralServiceAccountToken_basic
=== PAUSE TestEphemeralServiceAccountToken_basic
=== RUN   TestEphemeralServiceAccountToken_withDelegates
=== PAUSE TestEphemeralServiceAccountToken_withDelegates
=== RUN   TestEphemeralServiceAccountToken_withCustomLifetime
=== PAUSE TestEphemeralServiceAccountToken_withCustomLifetime
=== CONT  TestEphemeralServiceAccountToken_basic
=== CONT  TestEphemeralServiceAccountToken_withCustomLifetime
=== CONT  TestEphemeralServiceAccountToken_withDelegates
2024/11/06 16:47:14 [INFO] Authenticating using configured Google JSON 'credentials'...
2024/11/06 16:47:14 [INFO]   -- Scopes: [https://www.googleapis.com/auth/cloud-platform https://www.googleapis.com/auth/userinfo.email]
2024/11/06 16:47:14 [INFO] Authenticating using configured Google JSON 'credentials'...
2024/11/06 16:47:14 [INFO]   -- Scopes: [https://www.googleapis.com/auth/cloud-platform https://www.googleapis.com/auth/userinfo.email]
2024/11/06 16:47:14 [INFO] Authenticating using configured Google JSON 'credentials'...
2024/11/06 16:47:14 [INFO]   -- Scopes: [https://www.googleapis.com/auth/cloud-platform https://www.googleapis.com/auth/userinfo.email]
2024/11/06 16:47:14 [DEBUG] Waiting for state to become: [success]
2024/11/06 16:47:14 [INFO] Authenticating using configured Google JSON 'credentials'...
2024/11/06 16:47:14 [INFO]   -- Scopes: [https://www.googleapis.com/auth/cloud-platform https://www.googleapis.com/auth/userinfo.email]
2024/11/06 16:47:14 [DEBUG] Waiting for state to become: [success]
2024/11/06 16:47:14 [INFO] Authenticating using configured Google JSON 'credentials'...
2024/11/06 16:47:14 [INFO]   -- Scopes: [https://www.googleapis.com/auth/cloud-platform https://www.googleapis.com/auth/userinfo.email]
2024/11/06 16:47:14 [INFO] Authenticating using configured Google JSON 'credentials'...
2024/11/06 16:47:14 [INFO]   -- Scopes: [https://www.googleapis.com/auth/cloud-platform https://www.googleapis.com/auth/userinfo.email]
2024/11/06 16:47:14 [DEBUG] Waiting for state to become: [success]
2024/11/06 16:47:15 [INFO] Terraform is using this identity: mauricio-alvarezleon@hc-terraform-testing.iam.gserviceaccount.com
2024/11/06 16:47:15 [DEBUG] Verifying projects/hc-terraform-testing/serviceAccounts/tf-bootstrap-sa-delegates@hc-terraform-testing.iam.gserviceaccount.com as bootstrapped service account.
2024/11/06 16:47:15 [INFO] Instantiating Google Cloud IAM client for path https://iam.googleapis.com/
2024/11/06 16:47:15 [DEBUG] Retry Transport: starting RoundTrip retry loop
2024/11/06 16:47:15 [DEBUG] Retry Transport: request attempt 0
2024/11/06 16:47:15 [INFO] Terraform is using this identity: mauricio-alvarezleon@hc-terraform-testing.iam.gserviceaccount.com
2024/11/06 16:47:15 [DEBUG] Verifying projects/hc-terraform-testing/serviceAccounts/tf-bootstrap-sa-lifetime@hc-terraform-testing.iam.gserviceaccount.com as bootstrapped service account.
2024/11/06 16:47:15 [INFO] Instantiating Google Cloud IAM client for path https://iam.googleapis.com/
2024/11/06 16:47:15 [DEBUG] Retry Transport: starting RoundTrip retry loop
2024/11/06 16:47:15 [DEBUG] Retry Transport: request attempt 0
2024/11/06 16:47:15 [INFO] Terraform is using this identity: mauricio-alvarezleon@hc-terraform-testing.iam.gserviceaccount.com
2024/11/06 16:47:15 [DEBUG] Verifying projects/hc-terraform-testing/serviceAccounts/tf-bootstrap-sa-basic@hc-terraform-testing.iam.gserviceaccount.com as bootstrapped service account.
2024/11/06 16:47:15 [INFO] Instantiating Google Cloud IAM client for path https://iam.googleapis.com/
2024/11/06 16:47:15 [DEBUG] Retry Transport: starting RoundTrip retry loop
2024/11/06 16:47:15 [DEBUG] Retry Transport: request attempt 0
2024/11/06 16:47:15 [DEBUG] Retry Transport: Stopping retries, last request was successful
2024/11/06 16:47:15 [DEBUG] Retry Transport: Returning after 1 attempts
2024/11/06 16:47:15 [DEBUG] Setting service account permissions.
2024/11/06 16:47:15 [INFO] Instantiating Google Cloud IAM client for path https://iam.googleapis.com/
2024/11/06 16:47:15 [DEBUG] Retry Transport: Stopping retries, last request was successful
2024/11/06 16:47:15 [DEBUG] Retry Transport: Returning after 1 attempts
2024/11/06 16:47:15 [DEBUG] Setting service account permissions.
2024/11/06 16:47:15 [INFO] Instantiating Google Cloud IAM client for path https://iam.googleapis.com/
2024/11/06 16:47:15 [DEBUG] Retry Transport: starting RoundTrip retry loop
2024/11/06 16:47:15 [DEBUG] Retry Transport: request attempt 0
2024/11/06 16:47:15 [DEBUG] Retry Transport: starting RoundTrip retry loop
2024/11/06 16:47:15 [DEBUG] Retry Transport: request attempt 0
2024/11/06 16:47:15 [DEBUG] Retry Transport: Stopping retries, last request was successful
2024/11/06 16:47:15 [DEBUG] Retry Transport: Returning after 1 attempts
2024/11/06 16:47:15 [DEBUG] Setting service account permissions.
2024/11/06 16:47:15 [INFO] Instantiating Google Cloud IAM client for path https://iam.googleapis.com/
2024/11/06 16:47:15 [DEBUG] Retry Transport: starting RoundTrip retry loop
2024/11/06 16:47:15 [DEBUG] Retry Transport: request attempt 0
2024/11/06 16:47:16 [DEBUG] Retry Transport: Stopping retries, last request was successful
2024/11/06 16:47:16 [DEBUG] Retry Transport: Returning after 1 attempts
--- PASS: TestEphemeralServiceAccountToken_basic (26.47s)
--- PASS: TestEphemeralServiceAccountToken_withDelegates (26.69s)
--- PASS: TestEphemeralServiceAccountToken_withCustomLifetime (26.79s)
PASS
ok      github.com/hashicorp/terraform-provider-google/google/services/resourcemanager  31.149s

modular-magician · 2024-11-07T01:32:56Z

Tests analytics

Total tests: 4267
Passed tests: 3615
Skipped tests: 417
Affected tests: 235

Click here to see the affected service packages

Action taken

Found 235 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

SarahFrench

Here are some more review comments, mainly:

Requesting testing of the new validators
Requested changes to the acc test using delegates

...hird_party/terraform/services/resourcemanager/ephemeral_google_service_account_token_test.go

mmv1/third_party/terraform/services/resourcemanager/ephemeral_google_service_account_token.go

...hird_party/terraform/services/resourcemanager/ephemeral_google_service_account_token_test.go

…google_service_account_token_test.go Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com>

modular-magician · 2024-11-12T22:04:40Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 261 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 3 files changed, 261 insertions(+), 1 deletion(-))

modular-magician · 2024-11-12T22:05:05Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 261 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 3 files changed, 261 insertions(+), 1 deletion(-))

modular-magician · 2024-11-12T22:05:25Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 261 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 3 files changed, 261 insertions(+), 1 deletion(-))

modular-magician · 2024-11-12T23:16:48Z

Tests analytics

Total tests: 4270
Passed tests: 3846
Skipped tests: 417
Affected tests: 7

Click here to see the affected service packages

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2024-11-12T23:18:31Z

Tests analytics

Total tests: 4270
Passed tests: 3846
Skipped tests: 417
Affected tests: 7

Click here to see the affected service packages

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2024-11-12T23:18:32Z

Tests analytics

Total tests: 4270
Passed tests: 3845
Skipped tests: 417
Affected tests: 8

Click here to see the affected service packages

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2024-11-12T23:28:55Z

🔴 Tests failed during RECORDING mode:
TestAccCloudRunService_cloudRunServiceMulticontainerExample [Error message] [Debug log]
TestAccCloudbuildv2Connection_GlePrivConnection [Error message] [Debug log]
TestAccCloudbuildv2Connection_GlePrivUpdateConnection [Error message] [Debug log]
TestAccContainerCluster_withSecretManagerConfig [Error message] [Debug log]
TestAccEphemeralServiceAccountToken_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountToken_withCustomLifetime [Error message] [Debug log]
TestAccEphemeralServiceAccountToken_withDelegates [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-11-12T23:30:42Z

🔴 Tests failed during RECORDING mode:
TestAccCloudRunService_cloudRunServiceMulticontainerExample [Error message] [Debug log]
TestAccCloudbuildv2Connection_GlePrivConnection [Error message] [Debug log]
TestAccCloudbuildv2Connection_GlePrivUpdateConnection [Error message] [Debug log]
TestAccContainerCluster_withSecretManagerConfig [Error message] [Debug log]
TestAccEphemeralServiceAccountToken_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountToken_withCustomLifetime [Error message] [Debug log]
TestAccEphemeralServiceAccountToken_withDelegates [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-11-12T23:33:42Z

🟢 Tests passed during RECORDING mode:
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccCloudRunService_cloudRunServiceMulticontainerExample [Error message] [Debug log]
TestAccCloudbuildv2Connection_GlePrivConnection [Error message] [Debug log]
TestAccCloudbuildv2Connection_GlePrivUpdateConnection [Error message] [Debug log]
TestAccContainerCluster_withSecretManagerConfig [Error message] [Debug log]
TestAccEphemeralServiceAccountToken_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountToken_withCustomLifetime [Error message] [Debug log]
TestAccEphemeralServiceAccountToken_withDelegates [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

SarahFrench

I think this'll be the final review! The big thing is fixing the name, and the rest is making sure the code is easier to understand for people to understand if they're new to the plugin-framework (and weren't involved in this PR).

mmv1/third_party/terraform/services/resourcemanager/ephemeral_google_service_account_token.go

...hird_party/terraform/services/resourcemanager/ephemeral_google_service_account_token_test.go

mmv1/third_party/terraform/services/resourcemanager/ephemeral_google_service_account_token.go

SarahFrench

I just realised - this PR should also include some handwritten documentation for google_service_account_access_token! However Registry support for docs is currently in progress.

I think you can use the docs for the existing data source as a starting point : google_service_account_access_token. We'll need to get confirmation about the new folder name in this folder

mmv1/third_party/terraform/services/resourcemanager/ephemeral_google_service_account_token.go

modular-magician · 2024-11-14T02:11:07Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 261 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 3 files changed, 261 insertions(+), 1 deletion(-))

modular-magician · 2024-11-14T03:24:09Z

Tests analytics

Total tests: 4270
Passed tests: 3843
Skipped tests: 417
Affected tests: 10

Click here to see the affected service packages

Action taken

Found 10 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2024-11-14T03:43:19Z

🟢 Tests passed during RECORDING mode:
TestAccBackupDRBackupVault_fullUpdate [Debug log]
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccCloudRunService_cloudRunServiceMulticontainerExample [Error message] [Debug log]
TestAccCloudbuildv2Connection_GlePrivConnection [Error message] [Debug log]
TestAccCloudbuildv2Connection_GlePrivUpdateConnection [Error message] [Debug log]
TestAccContainerCluster_withFleetConfig [Error message] [Debug log]
TestAccContainerCluster_withSecretManagerConfig [Error message] [Debug log]
TestAccEphemeralServiceAccountToken_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountToken_withCustomLifetime [Error message] [Debug log]
TestAccEphemeralServiceAccountToken_withDelegates [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

SarahFrench

#12140 (comment)

SarahFrench

One final, final, final review and we can merge this to the feature branch. We should check the docs example in future but that should block merging the feature branch to main, not this PR.

mmv1/third_party/terraform/services/resourcemanager/ephemeral_google_service_account_token.go

SarahFrench · 2024-11-15T17:47:53Z

..._party/terraform/website/docs/ephemeral-resources/service_account_access_token.html.markdown

SarahFrench · 2024-11-15T17:51:51Z

..._party/terraform/website/docs/ephemeral-resources/service_account_access_token.html.markdown

+provider "google" {
+}
+
+data "google_client_config" "default" {
+  provider = google
+}
+
+ephemeral "google_service_account_access_token" "default" {
+  provider               = google
+  target_service_account = "service_B@projectB.iam.gserviceaccount.com"
+  scopes                 = ["userinfo-email", "cloud-platform"]
+  lifetime               = "300s"
+}
+
+provider "google" {
+  alias        = "impersonated"
+  access_token = ephemeral.google_service_account_access_token.default.access_token
+}
+
+data "google_client_openid_userinfo" "me" {
+  provider = google.impersonated
+}
+
+output "target-email" {
+  value = data.google_client_openid_userinfo.me.email
+}


Once the plan time bug is fixed we should test this - I'll make a jira ticket for that (non blocking on this PR)

modular-magician · 2024-11-15T18:13:30Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 344 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 344 insertions(+), 1 deletion(-))

modular-magician · 2024-11-15T19:25:40Z

Tests analytics

Total tests: 4270
Passed tests: 3843
Skipped tests: 417
Affected tests: 10

Click here to see the affected service packages

Action taken

Found 10 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2024-11-15T19:46:14Z

🟢 Tests passed during RECORDING mode:
TestAccBackupDRBackupVault_fullUpdate [Debug log]
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccCloudRunService_cloudRunServiceMulticontainerExample [Error message] [Debug log]
TestAccCloudbuildv2Connection_GlePrivConnection [Error message] [Debug log]
TestAccCloudbuildv2Connection_GlePrivUpdateConnection [Error message] [Debug log]
TestAccContainerCluster_withFleetConfig [Error message] [Debug log]
TestAccContainerCluster_withSecretManagerConfig [Error message] [Debug log]
TestAccEphemeralServiceAccountToken_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountToken_withCustomLifetime [Error message] [Debug log]
TestAccEphemeralServiceAccountToken_withDelegates [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

SarahFrench

This comment was marked as outdated.

Sign in to view

BBBmau force-pushed the support-service-account-token branch from 51639c8 to 8242932 Compare November 5, 2024 03:52

BBBmau commented Nov 5, 2024

View reviewed changes

mmv1/third_party/terraform/services/resourcemanager/ephemeral_google_service_account_token.go Outdated Show resolved Hide resolved

This comment was marked as outdated.

Sign in to view

SarahFrench reviewed Nov 5, 2024

View reviewed changes

mmv1/third_party/terraform/services/resourcemanager/ephemeral_google_service_account_token.go Outdated Show resolved Hide resolved

BBBmau force-pushed the support-service-account-token branch from 2cda8ad to a618711 Compare November 5, 2024 23:55

This comment was marked as outdated.

Sign in to view

BBBmau force-pushed the support-service-account-token branch from a618711 to 20c115f Compare November 6, 2024 00:36

This comment was marked as outdated.

Sign in to view

BBBmau marked this pull request as ready for review November 6, 2024 01:00

SarahFrench requested changes Nov 6, 2024

View reviewed changes

mmv1/third_party/terraform/services/resourcemanager/ephemeral_google_service_account_token.go Outdated Show resolved Hide resolved

...hird_party/terraform/services/resourcemanager/ephemeral_google_service_account_token_test.go Outdated Show resolved Hide resolved

SarahFrench reviewed Nov 6, 2024

View reviewed changes

mmv1/third_party/terraform/services/resourcemanager/ephemeral_google_service_account_token.go Outdated Show resolved Hide resolved

BBBmau mentioned this pull request Nov 6, 2024

ephemeral: add google_service_account_id_token #12141

Open

BBBmau force-pushed the support-service-account-token branch from b7d0840 to 79a87d0 Compare November 7, 2024 00:12

BBBmau mentioned this pull request Nov 7, 2024

move framework_validators.go to new fwvalidators package #12268

Merged

This comment was marked as outdated.

Sign in to view

SarahFrench reviewed Nov 7, 2024

View reviewed changes

Update mmv1/third_party/terraform/services/resourcemanager/ephemeral_…

8f98503

…google_service_account_token_test.go Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com>

BBBmau mentioned this pull request Nov 13, 2024

ephemeral: add ephemeral_google_service_account_key #12143

Draft

SarahFrench added a commit to SarahFrench/terraform-provider-google that referenced this pull request Nov 13, 2024

Apply changes from GoogleCloudPlatform/magic-modules#12140

582d765

SarahFrench changed the title ~~ephemeral: add ephemeral_google_service_account_token~~ ephemeral: add ephemeral_google_service_account_access_token Nov 13, 2024

SarahFrench reviewed Nov 13, 2024

View reviewed changes

SarahFrench reviewed Nov 14, 2024

View reviewed changes

mmv1/third_party/terraform/services/resourcemanager/ephemeral_google_service_account_token.go Outdated Show resolved Hide resolved

BBBmau added 4 commits November 13, 2024 17:45

rename to be service_account_access_token

13d2b22

add comment explaining default values not being allowed in schema

1b131e4

simplify StringSet(delegates)

816a36b

include description and markdwon description

70d8b7b

SarahFrench reviewed Nov 14, 2024

View reviewed changes

add ephemeral-resource markdwon doc and field descriptions

e5f1fbb

SarahFrench reviewed Nov 15, 2024

View reviewed changes

rename files

e4da3a6

SarahFrench approved these changes Nov 15, 2024

View reviewed changes

ephemeral: add ephemeral_google_service_account_access_token #12140

Are you sure you want to change the base?

ephemeral: add ephemeral_google_service_account_access_token #12140

Conversation

BBBmau commented Oct 25, 2024 • edited by SarahFrench Loading

This comment was marked as outdated.

This comment was marked as outdated.

BBBmau commented Nov 5, 2024

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

modular-magician commented Nov 6, 2024

Diff report

Errors

modular-magician commented Nov 6, 2024

Tests analytics

SarahFrench left a comment

Choose a reason for hiding this comment

SarahFrench left a comment

Choose a reason for hiding this comment

modular-magician commented Nov 7, 2024

Diff report

BBBmau commented Nov 7, 2024

modular-magician commented Nov 7, 2024

Tests analytics

Action taken

This comment was marked as outdated.

SarahFrench left a comment

Choose a reason for hiding this comment

modular-magician commented Nov 12, 2024

Diff report

modular-magician commented Nov 12, 2024

Diff report

modular-magician commented Nov 12, 2024

Diff report

modular-magician commented Nov 12, 2024

Tests analytics

Action taken

modular-magician commented Nov 12, 2024

Tests analytics

Action taken

modular-magician commented Nov 12, 2024

Tests analytics

Action taken

modular-magician commented Nov 12, 2024

modular-magician commented Nov 12, 2024

modular-magician commented Nov 12, 2024

SarahFrench left a comment

Choose a reason for hiding this comment

SarahFrench left a comment

Choose a reason for hiding this comment

modular-magician commented Nov 14, 2024

Diff report

modular-magician commented Nov 14, 2024

Tests analytics

Action taken

modular-magician commented Nov 14, 2024

SarahFrench left a comment

Choose a reason for hiding this comment

SarahFrench left a comment

Choose a reason for hiding this comment

SarahFrench Nov 15, 2024

Choose a reason for hiding this comment

SarahFrench Nov 15, 2024

Choose a reason for hiding this comment

SarahFrench Nov 15, 2024

Choose a reason for hiding this comment

modular-magician commented Nov 15, 2024

Diff report

modular-magician commented Nov 15, 2024

Tests analytics

Action taken

modular-magician commented Nov 15, 2024

SarahFrench left a comment

Choose a reason for hiding this comment

`ephemeral`: add `ephemeral_google_service_account_access_token` #12140

`ephemeral`: add `ephemeral_google_service_account_access_token` #12140

BBBmau commented Oct 25, 2024 •

edited by SarahFrench

Loading