Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement IapSettings resource. #12183

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

bryan0515
Copy link
Contributor

@bryan0515 bryan0515 commented Oct 29, 2024

This PR adds IAP Settings support.

Fixes hashicorp/terraform-provider-google#6471

This is a clone commit from
#11244.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_iap_settings`

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1955 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 1955 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 548 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 169 insertions(+))

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • iap
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccIapSettings_iapSettingsBasicExample
    🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 2101 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 2101 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 548 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 169 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_iap_settings (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_iap_settings" "primary" {
  access_settings {
    gcip_settings {
      tenant_ids = # value needed
    }
    oauth_settings {
      programmatic_clients = # value needed
    }
  }
}

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 2101 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 2101 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 548 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 169 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_iap_settings (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_iap_settings" "primary" {
  access_settings {
    gcip_settings {
      tenant_ids = # value needed
    }
    oauth_settings {
      programmatic_clients = # value needed
    }
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 79
Passed tests: 59
Skipped tests: 18
Affected tests: 2

Click here to see the affected service packages
  • iap

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccIapSettings_iapSettingsBasicExample
  • TestAccIapSettings_update

Get to know how VCR tests work

1 similar comment
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 79
Passed tests: 59
Skipped tests: 18
Affected tests: 2

Click here to see the affected service packages
  • iap

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccIapSettings_iapSettingsBasicExample
  • TestAccIapSettings_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccIapSettings_iapSettingsBasicExample [Debug log]
TestAccIapSettings_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@melinath melinath requested review from slevenick and removed request for hao-nan-li October 29, 2024 17:56
@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccIapSettings_iapSettingsBasicExample [Debug log]
TestAccIapSettings_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@slevenick slevenick requested review from zli82016 and removed request for slevenick October 29, 2024 18:30
@zli82016
Copy link
Member

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 2101 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 2101 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 548 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 169 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_iap_settings (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_iap_settings" "primary" {
  access_settings {
    gcip_settings {
      tenant_ids = # value needed
    }
    oauth_settings {
      programmatic_clients = # value needed
    }
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 79
Passed tests: 61
Skipped tests: 18
Affected tests: 0

Click here to see the affected service packages
  • iap

🟢 All tests passed!

View the build log

mmv1/products/iap/Settings.yaml Outdated Show resolved Hide resolved
Co-authored-by: Zhenhua Li <zhenhuali@google.com>
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 2101 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 2101 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 548 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 169 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_iap_settings (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_iap_settings" "primary" {
  access_settings {
    gcip_settings {
      tenant_ids = # value needed
    }
    oauth_settings {
      programmatic_clients = # value needed
    }
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 79
Passed tests: 61
Skipped tests: 18
Affected tests: 0

Click here to see the affected service packages
  • iap

🟢 All tests passed!

View the build log

Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for working on this.

@bryan0515 bryan0515 deleted the IapSettings branch October 29, 2024 20:44
niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Nov 1, 2024
Co-authored-by: Zhenhua Li <zhenhuali@google.com>
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Nov 5, 2024
Co-authored-by: Zhenhua Li <zhenhuali@google.com>
akshat-jindal-nit pushed a commit to akshat-jindal-nit/magic-modules that referenced this pull request Nov 18, 2024
Co-authored-by: Zhenhua Li <zhenhuali@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow configuring Identity-Aware Proxy (IAP) customization settings
3 participants