-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement IapSettings resource. #12183
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Errors
|
Tests analyticsTotal tests: 0 Click here to see the affected service packages
🔴 Tests were added that are skipped in VCR:
View the build log |
This is a clone commit from GoogleCloudPlatform#11244.
8953a47
to
02dce59
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_iap_settings" "primary" {
access_settings {
gcip_settings {
tenant_ids = # value needed
}
oauth_settings {
programmatic_clients = # value needed
}
}
}
|
1 similar comment
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_iap_settings" "primary" {
access_settings {
gcip_settings {
tenant_ids = # value needed
}
oauth_settings {
programmatic_clients = # value needed
}
}
}
|
Tests analyticsTotal tests: 79 Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
1 similar comment
Tests analyticsTotal tests: 79 Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
/gcbrun |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_iap_settings" "primary" {
access_settings {
gcip_settings {
tenant_ids = # value needed
}
oauth_settings {
programmatic_clients = # value needed
}
}
}
|
Tests analyticsTotal tests: 79 Click here to see the affected service packages
🟢 All tests passed! View the build log |
Co-authored-by: Zhenhua Li <zhenhuali@google.com>
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_iap_settings" "primary" {
access_settings {
gcip_settings {
tenant_ids = # value needed
}
oauth_settings {
programmatic_clients = # value needed
}
}
}
|
Tests analyticsTotal tests: 79 Click here to see the affected service packages
🟢 All tests passed! View the build log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for working on this.
Co-authored-by: Zhenhua Li <zhenhuali@google.com>
Co-authored-by: Zhenhua Li <zhenhuali@google.com>
Co-authored-by: Zhenhua Li <zhenhuali@google.com>
This PR adds IAP Settings support.
Fixes hashicorp/terraform-provider-google#6471
This is a clone commit from
#11244.
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.