Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TestAccDataprocCluster_withNetworkRefs #12335

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

surnaik
Copy link

@surnaik surnaik commented Nov 15, 2024

Dataproc doesn't allow cluster creation when internal_ip_only is set to true and Private Google Access is not enabled on the subnet. Since the subnetwork in this test is auto created, it does not have Private google access. Setting internal_ip_only to false

Fixes: https://github.com/hashicorp/hashicorp/terraform-provider-google/issues/20254
Fixes: hashicorp/terraform-provider-google#20254

Dataproc doesn't allow cluster creation when `internal_ip_only` is set to `true` and Private Google Access is not enabled on the subnet. Since the subnetwork in this test is auto created, it does not have Private google access. Setting `internal_ip_only` to false to fix the test.

Fixes: hashicorp/terraform-provider-google#20254
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@surnaik
Copy link
Author

surnaik commented Nov 15, 2024

make testacc TEST=./google/services/dataproc TESTARGS='-run=TestAccDataprocCluster_withNetworkRefs'
TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google/services/dataproc -v -run=TestAccDataprocCluster_withNetworkRefs -timeout 240m -ldflags="-X=github.com/hashicorp/terraform-provider-google/version.ProviderVersion=acc"
=== RUN   TestAccDataprocCluster_withNetworkRefs
=== PAUSE TestAccDataprocCluster_withNetworkRefs
=== CONT  TestAccDataprocCluster_withNetworkRefs
--- PASS: TestAccDataprocCluster_withNetworkRefs (419.57s)
PASS
ok  	github.com/hashicorp/terraform-provider-google/google/services/dataproc	420.025s

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 6 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 1 file changed, 6 insertions(+), 4 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 62
Passed tests: 56
Skipped tests: 6
Affected tests: 0

Click here to see the affected service packages
  • dataproc

🟢 All tests passed!

View the build log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccDataprocCluster_withNetworkRefs
2 participants