Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mirroring resources to Network Security. #12420

Merged
merged 3 commits into from
Nov 26, 2024
Merged

Conversation

duvni
Copy link
Contributor

@duvni duvni commented Nov 25, 2024

This PR is a promotion from google-private provider.
Removal CL: https://cloud-internal-review.git.corp.google.com/c/cloud-graphite-eng/magic-modules-private-overrides/+/49230

All Mirroring resources are bundled together in one PR because they're dependent on one another and cannot be tested separately.

`google_network_security_mirroring_deployment`, `google_network_security_mirroring_deployment_group`, `google_network_security_mirroring_endpoint_group_association`, `google_network_security_mirroring_endpoint_group`

Including examples and update tests.

Covering: MirroringDeploymentGroup, MirroringDeployment, MirroringEndpointGroup, MirroringEndpointGroupAssociation.
@github-actions github-actions bot requested a review from trodge November 25, 2024 09:39
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 780 insertions(+))
google-beta provider: Diff ( 21 files changed, 4155 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 364 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 43
Passed tests: 35
Skipped tests: 4
Affected tests: 4

Click here to see the affected service packages
  • networksecurity

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccNetworkSecurityMirroringDeploymentGroup_update
  • TestAccNetworkSecurityMirroringDeployment_update
  • TestAccNetworkSecurityMirroringEndpointGroupAssociation_update
  • TestAccNetworkSecurityMirroringEndpointGroup_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccNetworkSecurityMirroringDeploymentGroup_update [Debug log]
TestAccNetworkSecurityMirroringDeployment_update [Debug log]
TestAccNetworkSecurityMirroringEndpointGroupAssociation_update [Debug log]
TestAccNetworkSecurityMirroringEndpointGroup_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@github-actions github-actions bot requested a review from trodge November 26, 2024 19:58
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 800 insertions(+))
google-beta provider: Diff ( 21 files changed, 4175 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 364 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 43
Passed tests: 39
Skipped tests: 4
Affected tests: 0

Click here to see the affected service packages
  • networksecurity

🟢 All tests passed!

View the build log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants