Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enterprise_config field to GKE cluster object #12430

Merged
merged 5 commits into from
Dec 2, 2024

Conversation

bradhoekstra
Copy link
Contributor

@bradhoekstra bradhoekstra commented Nov 25, 2024

This PR adds support for configuring enterprise_config for GKE clusters (see https://cloud.google.com/kubernetes-engine/docs/how-to/enable-gkee#gcp-cluster).

Bug: b/380901610
Terraform Issue: hashicorp/terraform-provider-google#20355

container: added `enterprise_config` field to `google_container_cluster` resource

@bradhoekstra bradhoekstra changed the title Enterprise config Add enterprise_config field to GKE cluster object Nov 25, 2024
@bradhoekstra bradhoekstra marked this pull request as ready for review November 25, 2024 19:37
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 145 insertions(+))
google-beta provider: Diff ( 3 files changed, 145 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 219
Passed tests: 206
Skipped tests: 12
Affected tests: 1

Click here to see the affected service packages
  • container

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccContainerCluster_withEnterpriseConfig

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccContainerCluster_withEnterpriseConfig [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@bradhoekstra
Copy link
Contributor Author

bradhoekstra commented Nov 27, 2024

@slevenick Friendly ping to please review this PR.

Copy link

@slevenick This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link

github-actions bot commented Dec 2, 2024

@GoogleCloudPlatform/terraform-team @slevenick This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

Signed-off-by: Brad Hoekstra <bhoekstra@google.com>
@github-actions github-actions bot requested a review from slevenick December 2, 2024 15:35
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 173 insertions(+))
google-beta provider: Diff ( 3 files changed, 173 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 219
Passed tests: 206
Skipped tests: 12
Affected tests: 1

Click here to see the affected service packages
  • container

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccContainerCluster_withEnterpriseConfig

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccContainerCluster_withEnterpriseConfig [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@slevenick slevenick merged commit 311ba2f into GoogleCloudPlatform:main Dec 2, 2024
12 checks passed
amanMahendroo pushed a commit to amanMahendroo/magic-modules that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants