Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error drop column with reserved word #12626

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shoumoji
Copy link

@shoumoji shoumoji commented Dec 20, 2024

Fix: hashicorp/terraform-provider-google#20750

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

bigquery: fixed DROP COLUMN error with bigquery reserved word in `google_bigquery_table`

Signed-off-by: kataoka-ayumu <kataoka-ayumu1@dmm.com>
Copy link

google-cla bot commented Dec 20, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Dec 20, 2024
Comment on lines -2087 to +2091
droppedColumnsString := strings.Join(droppedColumns, ", DROP COLUMN ")
backquotedDroppedColumns := []string{}
for _, column := range droppedColumns {
backquotedDroppedColumns = append(backquotedDroppedColumns, fmt.Sprintf("`%s`", column))
}
droppedColumnsString := strings.Join(backquotedDroppedColumns, ", DROP COLUMN ")
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If droppedColumns = []string("column1", "column2") ,

backquotedDroppedColumns = []string("`column1`", "`column2`")
droppedColumnsString = "`column1`, DROP COLUMN `column2`"
dropColumnsDDL = "ALTER TABLE <table_id> DROP Column `column1`, DROP COLUMN `column2`"

@shoumoji shoumoji marked this pull request as ready for review December 20, 2024 01:49
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 5 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 1 file changed, 5 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 128
Passed tests: 114
Skipped tests: 10
Affected tests: 4

Click here to see the affected service packages
  • bigquery

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBigQueryTable_DropColumns
  • TestAccBigQueryTable_Update_SchemaWithPolicyTagsToEmptyPolicyTag
  • TestAccBigQueryTable_Update_SchemaWithPolicyTagsToEmptyPolicyTagNames
  • TestAccBigQueryTable_Update_SchemaWithPolicyTagsToNoPolicyTag

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccBigQueryTable_DropColumns [Debug log]
TestAccBigQueryTable_Update_SchemaWithPolicyTagsToEmptyPolicyTag [Debug log]
TestAccBigQueryTable_Update_SchemaWithPolicyTagsToEmptyPolicyTagNames [Debug log]
TestAccBigQueryTable_Update_SchemaWithPolicyTagsToNoPolicyTag [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@wj-chen
Copy link
Member

wj-chen commented Dec 20, 2024

Thank you for the fix! Can you also update the test in

func TestAccBigQueryTable_DropColumns(t *testing.T) {
to cover dropping a column with a reserved word in the name?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_bigquery_table error attempting to DROP COLUMN with column name containing reserved words
3 participants