-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for parameter manager parameter version datasource google_parameter_manager_parameter_version
#12653
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
@NickElliot Could you please review this PR? |
@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
Tests analyticsTotal tests: 13 Click here to see the affected service packages
Action takenFound 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🟢 All tests passed! |
@NickElliot Could you please review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…e_parameter_manager_parameter_version` (GoogleCloudPlatform#12653)
…e_parameter_manager_parameter_version` (GoogleCloudPlatform#12653)
Add support for parameter manager parameter version datasource
google_parameter_manager_parameter_version
.More info about parameter manager: https://cloud.google.com/secret-manager/parameter-manager/docs/overview
Note: This PR is dependent upon the parameter manager parameter version resource which will be added as a part of the PR #12641
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.