Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for parameter manager parameter version datasource google_parameter_manager_parameter_version #12653

Conversation

abheda-crest
Copy link
Contributor

@abheda-crest abheda-crest commented Dec 24, 2024

Add support for parameter manager parameter version datasource google_parameter_manager_parameter_version.

More info about parameter manager: https://cloud.google.com/secret-manager/parameter-manager/docs/overview

Note: This PR is dependent upon the parameter manager parameter version resource which will be added as a part of the PR #12641

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_parameter_manager_parameter_version`

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Dec 24, 2024
@abheda-crest abheda-crest marked this pull request as ready for review January 22, 2025 05:56
@github-actions github-actions bot requested a review from NickElliot January 22, 2025 05:56
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@abheda-crest
Copy link
Contributor Author

I've attached screenshot for the local test run for the test cases for google_parameter_manager_parameter_version datasource:

image

@abheda-crest
Copy link
Contributor Author

@NickElliot Could you please review this PR?

Copy link

@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 24, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 54 insertions(+))
google-beta provider: Diff ( 4 files changed, 449 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 13
Passed tests: 9
Skipped tests: 0
Affected tests: 4

Click here to see the affected service packages
  • parametermanager

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataSourceParameterManagerParameterVersion_basicWithParameterName
  • TestAccDataSourceParameterManagerParameterVersion_basicWithResourceReference
  • TestAccDataSourceParameterManagerParameterVersion_withJsonData
  • TestAccDataSourceParameterManagerParameterVersion_withYamlData

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDataSourceParameterManagerParameterVersion_basicWithParameterName [Debug log]
TestAccDataSourceParameterManagerParameterVersion_basicWithResourceReference [Debug log]
TestAccDataSourceParameterManagerParameterVersion_withJsonData [Debug log]
TestAccDataSourceParameterManagerParameterVersion_withYamlData [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@abheda-crest
Copy link
Contributor Author

@NickElliot Could you please review this PR?

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 27, 2025
Copy link
Contributor

@NickElliot NickElliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

anoopkverma-google pushed a commit to anoopkverma-google/magic-modules that referenced this pull request Jan 31, 2025
PerlMonker303 pushed a commit to PerlMonker303/magic-modules that referenced this pull request Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-approval Pull requests that need reviewer's approval to run presubmit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants