Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add google_chronicle_retrohunt resource to chronicle #12776

Conversation

ankitgoyal0301
Copy link
Contributor

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_chronicle_retrohunt`

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from c2thorn January 16, 2025 08:53
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 263 insertions(+))
google-beta provider: Diff ( 6 files changed, 848 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 109 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_chronicle_retrohunt (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_chronicle_retrohunt" "primary" {
  execution_interval {
    end_time   = # value needed
    start_time = # value needed
  }
  retrohunt = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 20
Passed tests: 19
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • chronicle

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccChronicleRetrohunt_chronicleRetrohuntBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccChronicleRetrohunt_chronicleRetrohuntBasicExample [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccChronicleRetrohunt_chronicleRetrohuntBasicExample [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 263 insertions(+))
google-beta provider: Diff ( 6 files changed, 848 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 109 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_chronicle_retrohunt (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_chronicle_retrohunt" "primary" {
  execution_interval {
    end_time   = # value needed
    start_time = # value needed
  }
  retrohunt = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 20
Passed tests: 19
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • chronicle

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccChronicleRetrohunt_chronicleRetrohuntBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccChronicleRetrohunt_chronicleRetrohuntBasicExample [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccChronicleRetrohunt_chronicleRetrohuntBasicExample [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 263 insertions(+))
google-beta provider: Diff ( 6 files changed, 849 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 109 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_chronicle_retrohunt (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_chronicle_retrohunt" "primary" {
  execution_interval {
    end_time   = # value needed
    start_time = # value needed
  }
  retrohunt = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 20
Passed tests: 19
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages
  • chronicle
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccChronicleRetrohunt_chronicleRetrohuntBasicExample
    🟢 All tests passed!

View the build log

Copy link
Member

@c2thorn c2thorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are skipping in VCR, we'll need to have the tests pass on a manual run in our environment. I'll trigger that on the next pass after we've gone through some of my questions

mmv1/products/chronicle/Retrohunt.yaml Outdated Show resolved Hide resolved
mmv1/products/chronicle/Retrohunt.yaml Show resolved Hide resolved
mmv1/products/chronicle/Retrohunt.yaml Outdated Show resolved Hide resolved
mmv1/products/chronicle/Retrohunt.yaml Show resolved Hide resolved
@github-actions github-actions bot requested a review from c2thorn January 17, 2025 05:53
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 263 insertions(+))
google-beta provider: Diff ( 6 files changed, 849 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 109 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_chronicle_retrohunt (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_chronicle_retrohunt" "primary" {
  execution_interval {
    end_time   = # value needed
    start_time = # value needed
  }
  retrohunt = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 20
Passed tests: 19
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages
  • chronicle
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccChronicleRetrohunt_chronicleRetrohuntBasicExample
    🟢 All tests passed!

View the build log

@c2thorn
Copy link
Member

c2thorn commented Jan 17, 2025

running test run of TestAccChronicleRetrohunt tests

Copy link
Member

@c2thorn c2thorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test run in teamcity passed, LGTM

PerlMonker303 pushed a commit to PerlMonker303/magic-modules that referenced this pull request Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants