Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource policy attachment #12812

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

Dawid212
Copy link
Contributor

This PR adds a new resource ResourcePolicyAttachment.

Related Issues

Release Note

See Write release notes for guidance.

`google_compute_resource_policy_attachment`

@github-actions github-actions bot requested a review from NickElliot January 20, 2025 10:25
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 20, 2025
Copy link

@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link

@GoogleCloudPlatform/terraform-team @NickElliot This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

@modular-magician modular-magician added service/compute-instances and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jan 28, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 577 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 577 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 115 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_resource_policy_attachment (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_resource_policy_attachment" "primary" {
  instance = # value needed
  name     = # value needed
  zone     = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1097
Passed tests: 1022
Skipped tests: 75
Affected tests: 0

Click here to see the affected service packages
  • compute

🟢 All tests passed!

View the build log

Co-authored-by: Nick Elliot <nickelliot@google.com>
@github-actions github-actions bot requested a review from NickElliot January 30, 2025 11:34
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 30, 2025
mmv1/products/compute/ResourcePolicyAttachment.yaml Outdated Show resolved Hide resolved
mmv1/products/compute/ResourcePolicyAttachment.yaml Outdated Show resolved Hide resolved
mmv1/products/compute/ResourcePolicyAttachment.yaml Outdated Show resolved Hide resolved
mmv1/products/compute/ResourcePolicyAttachment.yaml Outdated Show resolved Hide resolved
mmv1/products/compute/ResourcePolicyAttachment.yaml Outdated Show resolved Hide resolved
mmv1/products/compute/ResourcePolicyAttachment.yaml Outdated Show resolved Hide resolved
Dawid212 and others added 5 commits February 2, 2025 20:43
Co-authored-by: Nick Elliot <nickelliot@google.com>
Co-authored-by: Nick Elliot <nickelliot@google.com>
Co-authored-by: Nick Elliot <nickelliot@google.com>
Co-authored-by: Nick Elliot <nickelliot@google.com>
Co-authored-by: Nick Elliot <nickelliot@google.com>
@github-actions github-actions bot requested a review from NickElliot February 2, 2025 19:44
Co-authored-by: Nick Elliot <nickelliot@google.com>
@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Feb 3, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 578 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 578 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 115 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_resource_policy_attachment (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_resource_policy_attachment" "primary" {
  instance = # value needed
  name     = # value needed
  zone     = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1100
Passed tests: 1025
Skipped tests: 75
Affected tests: 0

Click here to see the affected service packages
  • compute

🟢 All tests passed!

View the build log

Copy link
Contributor

@NickElliot NickElliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add your example details to the ResourcePolicyAttachment yaml? see here: https://googlecloudplatform.github.io/magic-modules/test/test/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_compute_resource_policy attachment
3 participants