Make colab runtime startable/stoppable/upgradable

[bcreddy-gcp]

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

colab: Make colab runtime startable/stoppable/upgradable

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 175 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 175 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 22 insertions(+))
Open in Cloud Shell: Diff ( 5 files changed, 134 insertions(+))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 175 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 175 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 22 insertions(+))
Open in Cloud Shell: Diff ( 5 files changed, 134 insertions(+))

[modular-magician]

Tests analytics

Total tests: 9
Passed tests: 8
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• colab

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccColabRuntime_colabRuntimeStoppedExample

Get to know how VCR tests work

[modular-magician]

Tests analytics

Total tests: 9
Passed tests: 8
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• colab

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccColabRuntime_colabRuntimeStoppedExample

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccColabRuntime_colabRuntimeStoppedExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccColabRuntime_colabRuntimeStoppedExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 453 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 5 files changed, 453 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 22 insertions(+))
Open in Cloud Shell: Diff ( 5 files changed, 134 insertions(+))

[modular-magician]

Tests analytics

Total tests: 10
Passed tests: 9
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• colab

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccColabRuntime_update

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccColabRuntime_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 470 insertions(+), 66 deletions(-))
google-beta provider: Diff ( 5 files changed, 470 insertions(+), 66 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 22 insertions(+))
Open in Cloud Shell: Diff ( 5 files changed, 134 insertions(+))

[modular-magician]

Tests analytics

Total tests: 10
Passed tests: 9
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• colab

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccColabRuntime_update

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccColabRuntime_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[bcreddy-gcp]

Couple of questions @hao-nan-li.

1. Is this the right way to implement upgrade?
2. Not sure how to test upgrade runtime functionality. Newly created runtimes are not upgradable and there is no reliable way of creating upgradable runtimes. How do we go about this?

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 487 insertions(+), 65 deletions(-))
google-beta provider: Diff ( 5 files changed, 487 insertions(+), 65 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 22 insertions(+))
Open in Cloud Shell: Diff ( 5 files changed, 134 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_colab_runtime (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_colab_runtime" "primary" {
  upgrade_runtime = # value needed
}

[modular-magician]

Tests analytics

Total tests: 10
Passed tests: 10
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• colab

🟢 All tests passed!

View the build log