Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various Terraform google-beta test fixes #1364

Merged

Conversation

rileykarson
Copy link
Member

@rileykarson rileykarson commented Feb 8, 2019

Running a full CI run, I ran into a # of failing tests. These should fix most of them.


[all]

Changed Image.licenses to an array of resourcerefs instead of strings.

[terraform]

Various CI test fixes

[terraform-beta]

[ansible]

[inspec]

@modular-magician
Copy link
Collaborator

I am a robot that works on MagicModules PRs!

I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#420
depends: hashicorp/terraform-provider-google#3018
depends: modular-magician/ansible#186

@rileykarson
Copy link
Member Author

@modular-magician
Copy link
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit a2bd0ab) have been included in your existing downstream PRs.

@rileykarson
Copy link
Member Author

Got approval from @rambleraptor over message.

@modular-magician modular-magician merged commit bf1f204 into GoogleCloudPlatform:master Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants