Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix private_cluster and master_ipv4_cidr_block in upgrade guide #1386

Merged
merged 2 commits into from
Feb 14, 2019

Conversation

pdecat
Copy link
Contributor

@pdecat pdecat commented Feb 14, 2019


[all]

[terraform]

private_cluster and master_ipv4_cidr_block were not moved to google-beta but replaced by new fields.

hashicorp/terraform-provider-google#2395

GA since 2018/10/02: https://cloud.google.com/kubernetes-engine/release-notes#october-2-2018

[terraform-beta]

[ansible]

[inspec]

`private_cluster` and `master_ipv4_cidr_block` were not moved to google-beta but replaced by new fields.

hashicorp/terraform-provider-google#2395

GA since 2018/10/02: https://cloud.google.com/kubernetes-engine/release-notes#october-2-2018
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. They will authorize it to run through our CI pipeline, which will generate downstream PRs.

Thanks for your contribution! A human will be with you soon.

@modular-magician
Copy link
Collaborator

I am a robot that works on MagicModules PRs!

I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#438
depends: hashicorp/terraform-provider-google#3052

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rileykarson rileykarson changed the title google_container_cluster private_cluster and master_ipv4_cidr_block were not moved to google-beta Fix private_cluster and master_ipv4_cidr_block in upgrade guide Feb 14, 2019
Tracked submodules are build/terraform-beta build/terraform build/ansible build/inspec.
@modular-magician modular-magician merged commit 35fa2fd into GoogleCloudPlatform:master Feb 14, 2019
@pdecat pdecat deleted the patch-6 branch February 14, 2019 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants