Sort import regex's #1550
Sort import regex's #1550
Conversation
|
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesNo diff detected in terraform-google-conversion. New Pull RequestsI built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
provider/terraform/import.rb
Outdated
| (id_formats + [short_id_format, short_id_default_format]).uniq.reject(&:empty?) | ||
| # Regexes should be unique and ordered from most specific to least specific | ||
| (id_formats + [short_id_format, short_id_default_format]). | ||
| uniq.reject(&:empty?).sort_by{|i| i.count('/')}.reverse |
There was a problem hiding this comment.
you got a bunch of rubocop issues from spacing stuff but otherwise LGTM
|
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesterraform-provider-google-beta already has an open PR. New Pull RequestsI didn't open any new pull requests because of this PR. |
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
modular-magician
force-pushed
the
compute-router-import
branch
from
0b185af to
54c1fee
Compare
Regex's need to be ordered from the most specific to the least specific. This uses the number of slashes to indicate specificity.
fixes hashicorp/terraform-provider-google#3213
[all]
[terraform]
[terraform-beta]
[ansible]
[inspec]