Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap service accounts for impersonation tests #1612

Merged

Conversation

chrisst
Copy link
Contributor

@chrisst chrisst commented Apr 3, 2019

This should allow the impersonation tests added in hashicorp/terraform-provider-google#3211 to be able to pass without having to create a second service account by hand in our CI tests.


[all]

[terraform]

[terraform-beta]

[ansible]

[inspec]

@chrisst chrisst requested a review from paddycarver April 3, 2019 17:09
@chrisst
Copy link
Contributor Author

chrisst commented Apr 3, 2019

@paddycarver can you make sure GOOGLE_SERVICE_ACCOUNT is set in all our CI runs. I think it's missing in a few.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 656c1cc.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#582
depends: hashicorp/terraform-provider-google#3371

chrisst and others added 2 commits May 2, 2019 17:24
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician force-pushed the access-token-bootstrap branch from 656c1cc to b52ef54 Compare May 2, 2019 17:24
@modular-magician modular-magician merged commit c36f4e8 into GoogleCloudPlatform:master May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants