Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination to google projects data source #1670

Conversation

emilymye
Copy link
Contributor

@emilymye emilymye commented Apr 18, 2019

Fixes hashicorp/terraform-provider-google#3462

Tested this manually with pageSize = 1


[all]

[terraform]

Add pagination to google projects datasource

[terraform-beta]

Add pagination to google projects datasource

[ansible]

[inspec]

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 0133d2f.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#626
depends: hashicorp/terraform-provider-google#3464

emilymye and others added 2 commits April 19, 2019 21:16
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician force-pushed the data_source_google_projects_pages branch from 0133d2f to 9b7f6c2 Compare April 19, 2019 21:16
@modular-magician modular-magician merged commit 7fa80ee into GoogleCloudPlatform:master Apr 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_projects datasource truncates at 1,000 results
4 participants