Add node groups (sole-tenant nodes)

[emilymye]

Part 2 of hashicorp/terraform-provider-google#2700

EDIT: This also changes GetOK to GetOkExists in our url replacement function. Previous behavior was returning an empty string if the property had its zero value - for strings, this is the same (i.e. "") but this replaces zero int values with "" instead of "0". We weren't hitting this behavior before because most url params are strings or positive integers (ids, priority).

Todo:

• Add node config to compute instance (
• Add example/test that also adds VMs to node groups

---

[all]

[terraform]

Add node groups (sole-tenant nodes)

[terraform-beta]

Add node groups (sole-tenant nodes)

[ansible]

[inspec]

[modular-magician]

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 842ba5b5e48e6aabb9ea2421bb5ee0979320ef51.

Pull request statuses

No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#643
depends: GoogleCloudPlatform/terraform-google-conversion#64
depends: hashicorp/terraform-provider-google#3514

[rileykarson]

Just curious, is 0 a valid value?

[emilymye]

The docs are misleading but I tried it with zero using both TF and the REST API and it was fine. Would you like me to set the size to 0 in the tests?

[modular-magician]

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 2a22d70.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

[modular-magician]

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 3ee558e.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

[rileykarson]

Just curious if it's behaviour we'd tried out! I've been surprised how APIs handled 0 values in the past, Bigtable did something particularly silly if I remember right.

[modular-magician]

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 9d8182f.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

[modular-magician]

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 9c5225f.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.