Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Stackdriver Logging Metric resource #1702

Merged
merged 2 commits into from
May 3, 2019
Merged

Add Stackdriver Logging Metric resource #1702

merged 2 commits into from
May 3, 2019

Conversation

tysen
Copy link

@tysen tysen commented Apr 30, 2019

Fixes hashicorp/terraform-provider-google#1236

[all]

[terraform]

[terraform-beta]

[ansible]

[inspec]

@tysen tysen requested a review from rileykarson April 30, 2019 22:21
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 8d90faf79708c6aba448b90ec272ead0fbac9686.

Pull request statuses

No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#647
depends: GoogleCloudPlatform/terraform-google-conversion#67
depends: hashicorp/terraform-provider-google#3523

rileykarson
rileykarson reviewed May 1, 2019
View reviewed changes
Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thought I'd commented with my first pass yesterday. Turns out I forgot to click the button in this tab. Sent now.

products/logging/api.yaml Outdated Show resolved Hide resolved
products/logging/api.yaml Show resolved Hide resolved
products/logging/api.yaml Show resolved Hide resolved
products/logging/api.yaml Show resolved Hide resolved
products/logging/api.yaml Outdated Show resolved Hide resolved
products/logging/terraform.yaml Outdated Show resolved Hide resolved
@rileykarson
Copy link
Member

Looks like https://github.com/GoogleCloudPlatform/magic-modules/pull/1697/files#diff-b12861b106185324fa6bfdb16cbf1834R167 conflicted in transport.go, do you mind rebasing + pulling that in?

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 3b70058.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

rileykarson
rileykarson approved these changes May 3, 2019
View reviewed changes
Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM- just a few aesthetic comments, none of them blocking.

products/logging/terraform.yaml Outdated Show resolved Hide resolved
templates/terraform/examples/logging_metric_basic.tf.erb Outdated Show resolved Hide resolved
third_party/terraform/utils/transport.go Show resolved Hide resolved
third_party/terraform/tests/resource_logging_metric_test.go Outdated Show resolved Hide resolved
third_party/terraform/tests/resource_logging_metric_test.go Outdated Show resolved Hide resolved
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 3c9232d.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

Ty Larrabee and others added 2 commits May 3, 2019 19:30
@modular-magician
Add Stackdriver Logging Metric resource
1db38c8
@modular-magician
Update tracked submodules -> HEAD on Fri May 3 19:30:34 UTC 2019
2be17aa 
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician merged commit 0dad6e1 into GoogleCloudPlatform:master May 3, 2019
@tysen tysen deleted the metric branch May 3, 2019 19:35
@tysen tysen mentioned this pull request May 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rileykarson rileykarson rileykarson approved these changes

Assignees
No one assigned
Labels
automerged cla: yes downstream-generated terraform-google-conversion terraform-provider-google terraform-provider-google-beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[enhancement] Add support for log-based metrics
4 participants
@tysen @modular-magician @rileykarson @googlebot