Cloudrun beta implementation on alpha KNative #1820

chrisst · 2019-05-23T00:05:27Z

Publishing this as a WIP PR for early feedback (see the TODO checklist for the remaining work to be done) and get code generation working. This is an implementation of the beta version of CloudRun, however they are currently running against an alpha version of the KNative apis which means that the underlying object model could change when CloudRun moves to KNative beta. See KNative release details for more information on the beta implementation.

TODO

# make sure location is showing up in docs
# add the guides / references to api.yaml
# Address Domain Mapping correctly
# get Update working
# Support v1beta1 object model

Requested in hashicorp/terraform-provider-google#3421

Release Note for Downstream PRs (will be copied)

`google_cloud_run_service` - Set up a cloud run service
`google_cloud_run_domain_mapping` - Allows custom domains to map to a cloud run service

modular-magician · 2019-05-23T00:16:11Z

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 62b8fba960165d2c7e854753ca943ef9967ed341.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#757
depends: hashicorp/terraform-provider-google#3703

modular-magician · 2019-05-23T00:45:11Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, c105721.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
No diff detected in terraform-provider-google.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-05-24T17:24:13Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 5483d2f.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
No diff detected in terraform-provider-google.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-05-24T18:59:17Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 1dd06b4.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google#3714

modular-magician · 2019-06-24T21:45:11Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 9281d88.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-06-24T23:12:48Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, ff245bd.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

rambleraptor · 2019-07-02T23:04:46Z

Hi drive-by reviewer. Did you mean to commit "products/test"?

modular-magician · 2019-07-02T23:22:08Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, ec67b52.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-07-03T00:26:21Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 7572b07.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-07-15T18:24:35Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 8f8e728.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-07-15T18:28:23Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 673e7fd.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-07-22T19:41:11Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 8320c04.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-07-22T21:35:53Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 5f618a8.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

chrisst · 2019-07-22T22:55:39Z

@danawillow These resources are working, but they don't currently have a great experience in the error scenario. For example if you create a DomainMapping with bad values it doesn't do much validation on the POST and instead returns the object where the conditions include a Ready status of "status": "Unknown". That status will then transition to either True or False with an error message.

However we can't use "status": "Unknown" as an transition state to poll against because it can be a terminal state that requires more out of band input, such as:

{
        "type": "Ready",
        "status": "Unknown",
        "reason": "CertificatePending",
        "message": "Waiting for certificate provisioning. You must configure your DNS records for certificate issuance to begin and to accept HTTP traffic.",
        "lastTransitionTime": "2019-07-22T20:05:37.029Z"
      }

I think adding custom polling behavior using the status and reason of the Ready block is a slight improvement but I think it can be added in a follow on PR.

danawillow

I'm excited to see this moving forward!

products/cloudrun/api.yaml

danawillow · 2019-07-23T16:41:09Z

products/cloudrun/api.yaml

+    description: The location of the cloud run instance. eg us-central1
+    url_param_only: true
+    required: true
+  properties:


I put a few comments in, but generally I think most of these descriptions are hard to parse, and many contain information not relevant to our users. It would be nice if they could be given a once-over to try to make them a bit more user-friendly.

Also I'm generally a fan of putting things alphabetically, just to make it easier to find stuff later. Up to you though, don't worry about it if it messes with your tooling.

That's what I get for directly generating from REST docs, which directly generate from protos, which directly generate from....
I'll take a quick pass.

third_party/terraform/tests/resource_cloudrun_service_test.go

third_party/terraform/utils/config.go.erb

danawillow · 2019-07-23T16:51:35Z

products/cloudrun/terraform.yaml

+      kind: !ruby/object:Overrides::Terraform::PropertyOverride
+        exclude: true
+      apiVersion: !ruby/object:Overrides::Terraform::PropertyOverride
+        output: true


why output instead of exclude?

tbh - I'm worried that this value might be different even when querying the same endpoint. I am pretty sure that you will be able to retrieve Services created at v1alpha1 via the v1beta1 endpoint when it ships. So I thought it would be valuable down the road.

Since it's easier to add than to remove, would it make sense to wait until it becomes valuable to add it?

sound good.

danawillow · 2019-07-23T17:06:25Z

third_party/terraform/tests/resource_cloudrun_service_test.go

+	"github.com/hashicorp/terraform/helper/resource"
+)
+
+func TestAccCloudrunService_cloudrunServiceUpdate(t *testing.T) {


This failed when I tried to run it:

------- Stdout: ------- === RUN TestAccCloudrunService_cloudrunServiceUpdate === PAUSE TestAccCloudrunService_cloudrunServiceUpdate === CONT TestAccCloudrunService_cloudrunServiceUpdate --- FAIL: TestAccCloudrunService_cloudrunServiceUpdate (4.99s) testing.go:568: Step 2 error: errors during apply: Error: Error updating Service "tftest-cloudrun-lmgbra": googleapi: Error 409: Conflict for resource 'tftest-cloudrun-lmgbra' for version '1563901425614000'. on /opt/teamcity-agent/temp/buildTmp/tf-test772321307/main.tf line 2: (source code not available) FAIL

I have been able to reproduce this once, but not consistently. I suspect this is a race condition due to not handling polling until ready:true.

danawillow · 2019-07-23T17:10:05Z

templates/terraform/examples/cloudrun_service_basic.tf.erb

+  }
+}
+
+# The Service is ready to be used when the "Ready" condition is True


We can't wait in the resource itself because of the comment that you made about Unknown sometimes being a terminal state, right? Is there any way we can give feedback on that? I feel like doing it this way just pushes the problem down to our users.

Summary from in person conversation: It sounds like DomainMapping should be the exception and my understanding so far is that UNKNOWN should be a truly transitional state in most cases. We decided that Service needs this before it's really usable so I filed hashicorp/terraform-provider-google#4091 and I am opening a bug against the DomainMapping endpoint to see if we can figure out a better state resolution.

modular-magician · 2019-07-24T22:09:49Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 5e0c058.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-07-25T00:35:35Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, a6f7a15.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-07-26T20:07:01Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 44751db.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

danawillow

A few test/docs comments, but LGTM once those are resolved 🙌

danawillow · 2019-07-26T20:47:42Z

templates/terraform/examples/cloud_run_domain_mapping_basic.tf.erb

+resource "google_cloudrun_domain_mapping" "<%= ctx[:primary_resource_id] %>" {
+  location = "us-central1"
+  provider = "google-beta"
+  name = "<%= ctx[:vars]['cloudrun_domain_name'] %>"


Looks like this generated an empty name: https://github.com/terraform-providers/terraform-provider-google-beta/pull/757/files#diff-2b750590a17b245bd0d6188d7ed172b3

danawillow · 2019-07-26T20:51:14Z

templates/terraform/examples/cloud_run_domain_mapping_basic.tf.erb

@@ -0,0 +1,13 @@
+resource "google_cloudrun_domain_mapping" "<%= ctx[:primary_resource_id] %>" {


I think this should be google_cloud_run_domain_mapping now

danawillow · 2019-07-26T20:51:35Z

templates/terraform/examples/cloud_run_service_basic.tf.erb

@@ -0,0 +1,28 @@
+resource "google_cloudrun_service" "<%= ctx[:primary_resource_id] %>" {


danawillow · 2019-07-26T20:51:40Z

templates/terraform/examples/cloud_run_service_basic.tf.erb

@@ -0,0 +1,28 @@
+resource "google_cloudrun_service" "<%= ctx[:primary_resource_id] %>" {
+  name     = "<%= ctx[:vars]['cloudrun_service_name'] %>"


danawillow · 2019-07-26T20:51:52Z

templates/terraform/examples/cloud_run_service_basic.tf.erb

+# Due to Terraform and API limitations this is best accessed through a local variable
+locals {
+  cloudrun_status = {
+    for cond in google_cloudrun_service.default.status[0].conditions :


danawillow · 2019-07-26T20:53:04Z

products/cloudrun/api.yaml

+    Resource to hold the state and status of a user's domain mapping.
+
+    **Note:** Cloud Run as a product is in beta, however the REST API is currently still an alpha.
+    Please use this with caution as it may change when the resource moves to beta.


suggestion: s/resource/API (since we're in the beta provider right now, which could make things confusing)

modular-magician · 2019-07-26T21:21:36Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 34842b1.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

add cloudrun to providers block remove all output: false to simplify the yaml Add location property for building URLs Setting required fields and hacking name Removing fields that aren't core more updates to cloudrun service Create and Read are now working Flattened the spec block to get down to relevant properties hoisted name to a top level resoruce and hard coded apiVersion with encoders WIP adding cloudrun tests Cloud Run Service Updates Get generated tests up and running. Fix documentation for flattened objects Add docs and remove fields that can't be set Adding Service udpate test Add baseurl plubming Change cloudrun to beta format Add example version Removing test products changing for beta version change to beta endpoints

Also making cloudrun encoders generic Enrich Service examples

Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.

modular-magician · 2019-07-26T22:09:05Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 3388baa.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#984
depends: hashicorp/terraform-provider-google#4119

googlebot added the cla: yes label May 23, 2019

chrisst mentioned this pull request May 23, 2019

Cloudrun #1762

Closed

modular-magician added downstream-generated terraform-provider-google-beta terraform-provider-google labels May 23, 2019

chrisst force-pushed the cloudrun-canary branch from 62b8fba to c105721 Compare May 23, 2019 00:35

chrisst changed the title ~~[WIP] Cloudrun beta implementation on alpha KNative~~ [blocked] Cloudrun beta implementation on alpha KNative May 24, 2019

chrisst force-pushed the cloudrun-canary branch from 1dd06b4 to 3fb27d3 Compare May 24, 2019 20:27

chrisst mentioned this pull request Jun 7, 2019

Work in progress implementation of cloud run service #1643

Closed

chrisst force-pushed the cloudrun-canary branch from 3fb27d3 to 9281d88 Compare June 24, 2019 21:31

chrisst force-pushed the cloudrun-canary branch from 9281d88 to ff245bd Compare June 24, 2019 23:01

chrisst force-pushed the cloudrun-canary branch from ff245bd to e6a9373 Compare July 2, 2019 22:54

chrisst force-pushed the cloudrun-canary branch from 8f8e728 to 673e7fd Compare July 15, 2019 18:17

chrisst force-pushed the cloudrun-canary branch from 673e7fd to 8320c04 Compare July 22, 2019 19:30

chrisst changed the title ~~[blocked] Cloudrun beta implementation on alpha KNative~~ Cloudrun beta implementation on alpha KNative Jul 22, 2019

chrisst requested a review from danawillow July 22, 2019 21:23

danawillow suggested changes Jul 23, 2019

View reviewed changes

chrisst mentioned this pull request Jul 24, 2019

Cloud Run Services should poll for ready state hashicorp/terraform-provider-google#4091

Closed

chrisst force-pushed the cloudrun-canary branch from 3b84b9f to 5e0c058 Compare July 24, 2019 21:56

danawillow approved these changes Jul 26, 2019

View reviewed changes

chrisst added the changelog: new-resource label Jul 26, 2019

chrisst force-pushed the cloudrun-canary branch from a5fcbb9 to 34842b1 Compare July 26, 2019 21:49

modular-magician added the automerged label Jul 26, 2019

chrisst and others added 11 commits July 26, 2019 21:53

update tests for new object version. roll back to alpha endpoint

ed4bbce

fix generated service test

68f872e

Updates to handle Domain Mapping

9430386

Also making cloudrun encoders generic Enrich Service examples

code review feedback

aac81bc

Humanify some descriptions

0b61385

Finish cloud_run rename

47cccbd

more code review feedback

367fce3

Adding caveat about alpha endpoints

dd102ff

final rename pass

1e3cc90

Update tracked submodules -> HEAD on Fri Jul 26 21:53:24 UTC 2019

3388baa

Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.

modular-magician force-pushed the cloudrun-canary branch from 34842b1 to 3388baa Compare July 26, 2019 21:53

modular-magician merged commit 83b9fd5 into GoogleCloudPlatform:master Jul 26, 2019

		@@ -0,0 +1,13 @@
		resource "google_cloudrun_domain_mapping" "<%= ctx[:primary_resource_id] %>" {

		@@ -0,0 +1,28 @@
		resource "google_cloudrun_service" "<%= ctx[:primary_resource_id] %>" {

		@@ -0,0 +1,28 @@
		resource "google_cloudrun_service" "<%= ctx[:primary_resource_id] %>" {
		name = "<%= ctx[:vars]['cloudrun_service_name'] %>"

Cloudrun beta implementation on alpha KNative #1820

Cloudrun beta implementation on alpha KNative #1820

Conversation

chrisst commented May 23, 2019 • edited Loading

TODO

Release Note for Downstream PRs (will be copied)

modular-magician commented May 23, 2019

Pull request statuses

New Pull Requests

modular-magician commented May 23, 2019

Pull request statuses

New Pull Requests

modular-magician commented May 24, 2019

Pull request statuses

New Pull Requests

modular-magician commented May 24, 2019

Pull request statuses

New Pull Requests

modular-magician commented Jun 24, 2019

Pull request statuses

New Pull Requests

modular-magician commented Jun 24, 2019

Pull request statuses

New Pull Requests

rambleraptor commented Jul 2, 2019

modular-magician commented Jul 2, 2019

Pull request statuses

New Pull Requests

modular-magician commented Jul 3, 2019

Pull request statuses

New Pull Requests

modular-magician commented Jul 15, 2019

Pull request statuses

New Pull Requests

modular-magician commented Jul 15, 2019

Pull request statuses

New Pull Requests

modular-magician commented Jul 22, 2019

Pull request statuses

New Pull Requests

modular-magician commented Jul 22, 2019

Pull request statuses

New Pull Requests

chrisst commented Jul 22, 2019

danawillow left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

modular-magician commented Jul 24, 2019

Pull request statuses

New Pull Requests

modular-magician commented Jul 25, 2019

Pull request statuses

New Pull Requests

modular-magician commented Jul 26, 2019

Pull request statuses

New Pull Requests

danawillow left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

modular-magician commented Jul 26, 2019

Pull request statuses

New Pull Requests

modular-magician commented Jul 26, 2019

Pull request statuses

New Pull Requests

chrisst commented May 23, 2019 •

edited

Loading