-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark DiskEncryptionKey.rawKey as sensitive for Terraform #2728
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. They will authorize it to run through our CI pipeline, which will generate downstream PRs. Thanks for your contribution! A human will be with you soon. @emilymye, please review this PR or find an appropriate assignee. |
products/compute/terraform.yaml
Outdated
@@ -401,6 +401,8 @@ overrides: !ruby/object:Overrides::ResourceOverrides | |||
[google_compute_image data source](/docs/providers/google/d/datasource_compute_image.html). | |||
For instance, the image `centos-6-v20180104` includes its family name `centos-6`. | |||
These images can be referred by family name here. | |||
DiskEncryptionKey.rawKey: !ruby/object:Overrides::Terraform::PropertyOverride |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this needs to be lowercase camel, but once that's done it should be ok!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick look and good catch, fixed it in 219cfe6.
CCLA should be signed soonish as well when I get added to the group from our team.
@Shegox let me know when you've gotten the CLA fixed or comment/edit PR and the googlebot should fix it? i can also override |
@emilymye I'm still waiting on the internal process to get added to our corporate CLA group. I would like to give it another day and otherwise just do it as a personal contribution otherwise. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. They will authorize it to run through our CI pipeline, which will generate downstream PRs. Thanks for your contribution! A human will be with you soon. @danawillow, please review this PR or find an appropriate assignee. |
Thanks @modular-magician, but looks like @emilymye has this one covered :) |
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesNo diff detected in terraform-google-conversion. New Pull RequestsI built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesNo diff detected in terraform-google-conversion. New Pull RequestsI built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
on-behalf-of: @SAP <tobias.gabriel@sap.com>
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@Shegox I moved this over to #2766 - I merged the downstreams but didn't realize merge would fail on this PR because it's from a |
merged via #2766, closing |
This PR marks the raw disk encryption key in Terraform as sensitive and therefore doesn't output it to the console log.
Inspired by:
magic-modules/products/compute/terraform.yaml
Lines 1445 to 1452 in b67500f
I'm not 100% sure if changes to at other points are required or not.
Changes need to end in the end in the terraform-provider-google resource_compute_disk.
Release Note Template for Downstream PRs (will be copied)