DNS managed zone DS test ignores for beta-only fields #2804
Conversation
|
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesNo diff detected in terraform-google-conversion. New Pull RequestsI built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
| @@ -24,6 +24,8 @@ func TestAccDataSourceDnsManagedZone_basic(t *testing.T) { | |||
| map[string]struct{}{ | |||
| "dnssec_config.#": {}, | |||
| "private_visibility_config.#": {}, | |||
| "peering_config.#": {}, | |||
There was a problem hiding this comment.
If these are only ignored in GA we should wrap them in unless ga so that they are still tested in beta. That will also remind us to un-ignore them once they go GA.
|
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesterraform-provider-google-beta already has an open PR. New Pull RequestsI didn't open any new pull requests because of this PR. |
slevenick
force-pushed
the
dns-managed-zone-ds-beta
branch
from
ec0fcd5 to
2f8fdf0
Compare
|
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesNo diff detected in terraform-provider-google-beta. New Pull RequestsI didn't open any new pull requests because of this PR. |
Fixes TestAccDataSourceDnsManagedZone_basic in beta which gets extra fields in the response
Release Note Template for Downstream PRs (will be copied)