Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sleep so google_project is ready before returning #3388

Merged
merged 1 commit into from
Apr 21, 2020

Conversation

rileykarson
Copy link
Member

Fixes hashicorp/terraform-provider-google#5649

Release Note Template for Downstream PRs (will be copied)

resourcemanager: added a wait to `google_project` so that projects are more likely to be ready before the resource finishes creation

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 4 insertions(+))
Terraform Beta: Diff ( 1 file changed, 4 insertions(+))

Copy link
Contributor

@chrisst chrisst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand why this is pretty close to the only solution but it makes me so sad. Is there an upstream bug for this? I'd love to attach a TODO with the bug number so it can be removed once this API starts behaving better.

@rileykarson
Copy link
Member Author

Ehh- I'm not sure that it will. There's a lot of setup at project create time, unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants