Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made project_service.service validation reject invalid service domains #4722

Merged
merged 1 commit into from
Apr 23, 2021

Conversation

melinath
Copy link
Member

@melinath melinath commented Apr 21, 2021

Resolved hashicorp/terraform-provider-google#8875

There are a variety of supported domains (and more may be added). I think adding a simple check for the domain being plausible (i.e. "does it contain a period") should catch simple typos like the one in the linked issue while also being future-proof.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

serviceusage: Made `google_project_service.service` validation reject invalid service domains that don't contain a period

@google-cla google-cla bot added the cla: yes label Apr 21, 2021
@melinath melinath requested review from a team and ScottSuarez and removed request for a team April 21, 2021 16:46
@modular-magician

This comment has been minimized.

@modular-magician

This comment has been minimized.

@melinath
Copy link
Member Author

/gcbrun - failure was unrelated

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 54 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 2 files changed, 54 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=183635"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeBackendService_internalLoadBalancing You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=183637"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_project_service module needs to handle incorrect GCP API names properly
3 participants