Properly encode paths for google_storage_object_access_control

[melinath]

Resolved hashicorp/terraform-provider-google#9457

It looks like this ended up basically identical to #1759. @rileykarson long shot but do you happen to remember what issues you ran into with that solution?

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

storage: fixed handling of object paths that contain slashes for `google_storage_object_access_control`

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
Terraform Beta: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 7 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 3 files changed, 7 insertions(+), 7 deletions(-))
TF Conversion: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
Inspec: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

[rileykarson]

thinking out loud: id is only read during import, and we actually read import_format there instead. We don't need to annotate this line b/c we never need to recreate the id based on the template.

[melinath]

I was also concerned that changing this line might be backwards-incompatible? but I'm not sure if that's true.

[rileykarson]

I don't remember what was generating weirdly, import formats probably? It's, uh, been a while haha.

[melinath]

I don't remember what was generating weirdly, import formats probably? It's, uh, been a while haha.

okay, well, if it looks fine to you now I guess we're probably fine 😂

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 46 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 3 files changed, 46 insertions(+), 7 deletions(-))
TF Conversion: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
Inspec: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeInstance_updateRunning_desiredStatusNotSet_notAllowStoppingForUpdate|TestAccComputeInstance_updateRunning_desiredStatusRunning_notAllowStoppingForUpdate|TestAccContainerNodePool_withGPU|TestAccStorageObjectAccessControl_update|TestAccStorageObjectAcl_basic|TestAccStorageObjectAcl_downgrade|TestAccStorageObjectAcl_predefinedToExplicit|TestAccStorageObjectAcl_upgrade|TestAccStorageObjectAcl_predefined|TestAccStorageObjectAcl_explicitToPredefined|TestAccStorageObjectAcl_unordered You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=194844

[modular-magician]

Tests failed during RECORDING mode: TestAccContainerNodePool_withGPU Please fix these to complete your PR

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccContainerNodePool_withGPU|TestAccStorageObjectAccessControl_updateWithSlashes You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=194847

[modular-magician]

Tests failed during RECORDING mode: TestAccContainerNodePool_withGPU Please fix these to complete your PR

[melinath]

TestAccContainerNodePool_withGPU failure is unrelated.