Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore project on read and remove custom import on google_os_config_guest_policies #5172

Merged

Conversation

ScottSuarez
Copy link
Contributor

closes hashicorp/terraform-provider-google#9955
Release Note Template for Downstream PRs (will be copied)

osconfig: fixed import on google_os_config_guest_policies

@google-cla google-cla bot added the cla: yes label Sep 2, 2021
@ScottSuarez ScottSuarez requested review from a team and melinath and removed request for a team September 2, 2021 23:02
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
Terraform Beta: Diff ( 4 files changed, 18 insertions(+), 10 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeOrganizationSecurityPolicyAssociation_organizationSecurityPolicyAssociationBasicExample|TestAccFirebaseWebApp_firebaseWebAppBasicExample|TestAccOSConfigGuestPolicies_osConfigGuestPoliciesBasicExample|TestAccOSConfigGuestPolicies_osConfigGuestPoliciesPackagesExample|TestAccOSConfigGuestPolicies_osConfigGuestPoliciesRecipesExample You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=204148

@ScottSuarez
Copy link
Contributor Author

/gcbrun

@ScottSuarez
Copy link
Contributor Author

oo oops... tests already passed for this one ! ^^ @melinath

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
Terraform Beta: Diff ( 3 files changed, 17 insertions(+), 9 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeOrganizationSecurityPolicyAssociation_organizationSecurityPolicyAssociationBasicExample|TestAccFirebaseWebApp_firebaseWebAppBasicExample You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=204240

@modular-magician
Copy link
Collaborator

Tests failed during RECORDING mode: TestAccComputeOrganizationSecurityPolicyAssociation_organizationSecurityPolicyAssociationBasicExample|TestAccFirebaseWebApp_firebaseWebAppBasicExample Please fix these to complete your PR

Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix TestAccOSConfigGuestPolicies_*
3 participants