-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/NetLB connection tracking #5207
Feature/NetLB connection tracking #5207
Conversation
connection tracking + strong session affinity acceptance tests
Oops! It looks like you're using an unknown release-note type in your changelog entries:
Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md. |
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @melinath, please review this PR or find an appropriate assignee. |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 3 files changed, 342 insertions(+), 3 deletions(-)) |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 3 files changed, 343 insertions(+), 3 deletions(-)) |
/gcbrun |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 3 files changed, 343 insertions(+), 3 deletions(-)) |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeRegionBackendService_regionBackendServiceConnectionTrackingExample|TestAccComputeRegionBackendService_regionBackendServiceStrongAffinityExample|TestAccComputeServiceAttachment_serviceAttachmentBasicExample|TestAccDNSRecordSet_Update|TestAccDNSRecordSet_basic|TestAccDNSRecordSet_nestedNS|TestAccDNSRecordSet_changeType|TestAccDNSRecordSet_quotedTXT|TestAccDNSRecordSet_uppercaseMX You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=206607 |
manual rerun here |
/gcbrun |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 3 files changed, 343 insertions(+), 3 deletions(-)) |
/gcbrun |
1 similar comment
/gcbrun |
…m/danielmarzini/magic-modules into feature/netlb-connection-tracking
Testing to see why the build seems unhappy w/ @ScottSuarez /gcbrun |
Co-authored-by: Scott Suarez <ScottSuarez@google.com>
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 3 files changed, 292 insertions(+), 3 deletions(-)) |
/gcbrun |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 3 files changed, 292 insertions(+), 3 deletions(-)) |
Co-authored-by: Scott Suarez <ScottSuarez@google.com> Co-authored-by: Roberto Jung Drebes <drebes@users.noreply.github.com>
Co-authored-by: Scott Suarez <ScottSuarez@google.com> Co-authored-by: Roberto Jung Drebes <drebes@users.noreply.github.com>
…orm#5273) * Revert "Revert "Feature/NetLB connection tracking (GoogleCloudPlatform#5207)" (GoogleCloudPlatform#5272)" This reverts commit 2e54775. * Marked connectionTrackingPolicy as beta-only * Marked example as beta-only
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)