Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/NetLB connection tracking #5207

Merged
merged 11 commits into from
Sep 23, 2021
Merged

Feature/NetLB connection tracking #5207

merged 11 commits into from
Sep 23, 2021

Conversation

danielmarzini
Copy link
Contributor

@danielmarzini danielmarzini commented Sep 16, 2021

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

 compute: added NetLB support for Connection Tracking as `connectionTrackingPolicy` in `RegionBackendService`

@google-cla google-cla bot added the cla: yes label Sep 16, 2021
@modular-magician
Copy link
Collaborator

Oops! It looks like you're using an unknown release-note type in your changelog entries:

  • REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@melinath, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 342 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 3 files changed, 342 insertions(+), 3 deletions(-))
TF Conversion: Diff ( 1 file changed, 51 insertions(+))
TF OiCS: Diff ( 8 files changed, 246 insertions(+))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 343 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 4 files changed, 344 insertions(+), 4 deletions(-))
TF Conversion: Diff ( 1 file changed, 51 insertions(+))
TF OiCS: Diff ( 8 files changed, 246 insertions(+))

@danielmarzini danielmarzini marked this pull request as ready for review September 16, 2021 15:38
@melinath melinath requested review from a team and ScottSuarez and removed request for melinath and a team September 17, 2021 23:47
@ScottSuarez
Copy link
Contributor

/gcbrun

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 343 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 4 files changed, 344 insertions(+), 4 deletions(-))
TF Conversion: Diff ( 1 file changed, 51 insertions(+))
TF OiCS: Diff ( 8 files changed, 246 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeRegionBackendService_regionBackendServiceConnectionTrackingExample|TestAccComputeRegionBackendService_regionBackendServiceStrongAffinityExample|TestAccComputeServiceAttachment_serviceAttachmentBasicExample|TestAccDNSRecordSet_Update|TestAccDNSRecordSet_basic|TestAccDNSRecordSet_nestedNS|TestAccDNSRecordSet_changeType|TestAccDNSRecordSet_quotedTXT|TestAccDNSRecordSet_uppercaseMX You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=206607

@ScottSuarez
Copy link
Contributor

@ScottSuarez
Copy link
Contributor

/gcbrun

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 343 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 4 files changed, 344 insertions(+), 4 deletions(-))
TF Conversion: Diff ( 1 file changed, 51 insertions(+))
TF OiCS: Diff ( 8 files changed, 246 insertions(+))

@ScottSuarez
Copy link
Contributor

/gcbrun

1 similar comment
@danielmarzini
Copy link
Contributor Author

/gcbrun

@rileykarson
Copy link
Member

Testing to see why the build seems unhappy w/ @ScottSuarez

/gcbrun

mmv1/products/compute/terraform.yaml Outdated Show resolved Hide resolved
Co-authored-by: Scott Suarez <ScottSuarez@google.com>
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 292 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 4 files changed, 293 insertions(+), 4 deletions(-))
TF Conversion: Diff ( 1 file changed, 51 insertions(+))
TF OiCS: Diff ( 4 files changed, 124 insertions(+))

@ScottSuarez
Copy link
Contributor

/gcbrun

@ScottSuarez ScottSuarez self-requested a review September 23, 2021 17:33
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 292 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 5 files changed, 294 insertions(+), 6 deletions(-))
TF Conversion: Diff ( 1 file changed, 51 insertions(+))
TF OiCS: Diff ( 4 files changed, 124 insertions(+))

@ScottSuarez ScottSuarez merged commit f10f7b7 into GoogleCloudPlatform:master Sep 23, 2021
@danielmarzini danielmarzini deleted the feature/netlb-connection-tracking branch September 24, 2021 08:08
trodge pushed a commit to trodge/magic-modules that referenced this pull request Sep 28, 2021
Co-authored-by: Scott Suarez <ScottSuarez@google.com>
Co-authored-by: Roberto Jung Drebes <drebes@users.noreply.github.com>
melinath added a commit that referenced this pull request Oct 4, 2021
melinath added a commit that referenced this pull request Oct 4, 2021
melinath added a commit that referenced this pull request Oct 4, 2021
melinath added a commit that referenced this pull request Oct 4, 2021
* Revert "Revert "Feature/NetLB connection tracking (#5207)" (#5272)"

This reverts commit 2e54775.

* Marked connectionTrackingPolicy as beta-only

* Marked example as beta-only
khajduczenia pushed a commit to khajduczenia/magic-modules that referenced this pull request Oct 12, 2021
Co-authored-by: Scott Suarez <ScottSuarez@google.com>
Co-authored-by: Roberto Jung Drebes <drebes@users.noreply.github.com>
khajduczenia pushed a commit to khajduczenia/magic-modules that referenced this pull request Oct 12, 2021
khajduczenia pushed a commit to khajduczenia/magic-modules that referenced this pull request Oct 12, 2021
…orm#5273)

* Revert "Revert "Feature/NetLB connection tracking (GoogleCloudPlatform#5207)" (GoogleCloudPlatform#5272)"

This reverts commit 2e54775.

* Marked connectionTrackingPolicy as beta-only

* Marked example as beta-only
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants